Localize native MTP adapter runsettings resources#9897
Merged
Conversation
PR #9748 added a native MTP copy of the runsettings warning strings to PlatformAdapterResources, but the *.xlf targets were left untranslated (state=new with English text). This broke UnsupportedRunSettingsEntriesAreFlagged_Localization, which asserts French/Italian output. Port the verbatim-identical translations that already ship in the VSTestBridge ExtensionResources.*.xlf into PlatformAdapterResources.*.xlf (11 trans-units x 13 languages), flipping each target from state=new to state=translated. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e14a793a-02df-4926-bbea-7fb59e22ff59
Contributor
There was a problem hiding this comment.
Pull request overview
Localizes native MTP adapter runsettings messages using existing VSTestBridge translations.
Changes:
- Marks 143 resource targets as translated across 13 locales.
- Restores localized runsettings warnings and option descriptions.
Show a summary per file
| File | Description |
|---|---|
PlatformAdapterResources.cs.xlf |
Adds Czech translations. |
PlatformAdapterResources.de.xlf |
Adds German translations. |
PlatformAdapterResources.es.xlf |
Adds Spanish translations. |
PlatformAdapterResources.fr.xlf |
Adds French translations. |
PlatformAdapterResources.it.xlf |
Adds Italian translations. |
PlatformAdapterResources.ja.xlf |
Adds Japanese translations. |
PlatformAdapterResources.ko.xlf |
Adds Korean translations. |
PlatformAdapterResources.pl.xlf |
Adds Polish translations. |
PlatformAdapterResources.pt-BR.xlf |
Adds Brazilian Portuguese translations. |
PlatformAdapterResources.ru.xlf |
Adds Russian translations. |
PlatformAdapterResources.tr.xlf |
Adds Turkish translations. |
PlatformAdapterResources.zh-Hans.xlf |
Adds Simplified Chinese translations. |
PlatformAdapterResources.zh-Hant.xlf |
Adds Traditional Chinese translations. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 13
- Review effort level: Medium
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">.runsettings 檔案無效，遺漏 '<RunSettings>' 屬性</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">.runsettings 文件无效，缺少 '<RunSettings>' 属性</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Geçersiz .runsettings dosyası, '<RunSettings>' özniteliği eksik</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Недопустимый файл .runsettings, отсутствует атрибут "<RunSettings>"</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Arquivo .runsettings inválido, o atributo "<RunSettings>" está ausente</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">File .runsettings non valido. Attributo '<RunSettings>' mancante</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Fichier .runsettings non valide, « <RunSettings> » attribut est manquant</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Archivo .runsettings no válido, falta el atributo "<RunSettings>"</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Ungültige .runsettings-Datei, "<RunSettings>"-Attribut fehlt.</target> |
| <trans-unit id="MissingRunSettingsAttribute"> | ||
| <source>Invalid .runsettings file, '<RunSettings>' attribute is missing</source> | ||
| <target state="new">Invalid .runsettings file, '<RunSettings>' attribute is missing</target> | ||
| <target state="translated">Neplatný soubor .runsettings. Chybí atribut <RunSettings>.</target> |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Policy Violation: Manual XLF Edits
The repository localization guidelines state:
NEVER manually modify
*.xlffiles. Instead, regenerate them by runningdotnet msbuild <project>.csproj /t:UpdateXlf.
This PR manually edits all 13 .xlf files. The correct workflow is:
- Add/update the translated strings in the
.resxfile (or the localization system that feeds translations). - Run
dotnet msbuild src/Adapter/MSTest.TestAdapter/MSTest.TestAdapter.csproj /t:UpdateXlfto regenerate the.xlffiles.
Please regenerate via UpdateXlf to ensure the files stay consistent with the tooling expected format and avoid drift.
Other observations (no blocking issues beyond the policy violation):
- The 11 string IDs are updated consistently across all 13 locales ✓
state=new→state=translatedis the correct transition ✓- Locked terms (
.runsettings,<RunSettings>,{0}placeholders) appear preserved in the translations ✓ - No functional code changes — risk is low ✓
microsoft-github-policy-service
Bot
added
the
needs/author-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UnsupportedRunSettingsEntriesAreFlagged_Localizationis broken onmain.PR #9748 (native MTP integration for MSTest) added a new copy of the runsettings warning strings to
MSTest.TestAdapter'sPlatformAdapterResources. Since the test asset usesEnableMSTestRunner=true, it now hits the native path (MSTestRunSettings.cs→PlatformAdapterResources) instead of the old VSTestBridge path.However, every
PlatformAdapterResources.*.xlftarget was stillstate="new"with the English text, so no French/Italian output was ever produced and the test's localized assertions failed.Fix
Ported the already-shipping, verbatim-identical translations from
Microsoft.Testing.Extensions.VSTestBridge'sExtensionResources.*.xlfintoPlatformAdapterResources.*.xlf, matching by exact<source>text. This fills 11 trans-units × 13 languages (143 targets), flipping each target fromstate="new"tostate="translated".Notes:
<target>lines changed (clean 143/143 diff); CRLF + UTF-8 BOM preserved.dotnet msbuild /t:UpdateXlfwill not undo this — it never overwrites existing translated targets, it only syncs sources.Verification
.\build.cmd -pack -c Release, then ran the acceptance test: