docs(squad): Scribe merges CI workflow conventions into decisions.md#10
Merged
Conversation
Merge boromir-pr9-review-fixes.md inbox item into decisions.md as decision #4 — CI Workflow Conventions. Five conventions established: - Always use global-json-file: global.json in setup-dotnet - Use nuGetVersion for /p:Version in dotnet build - squad-test.yml triggers on pull_request only - Surgical use of continue-on-error - Comments must not contradict code Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
SummarySummary
CoverageAppHost - 0%
Domain - 93.4%
ServiceDefaults - 0%
Web - 68.9%
|
Contributor
|
There was a problem hiding this comment.
Pull request overview
Merges the CI workflow conventions captured in the PR #9 review-fix inbox note into the canonical .squad/decisions.md as Decision #4, and leaves a tombstone in the inbox file to indicate it’s been merged.
Changes:
- Renumbered existing decisions to keep numbering sequential after the existing Decision #1.
- Added Decision #4: CI Workflow Conventions to
.squad/decisions.md. - Replaced the inbox decision note with a “merged” tombstone comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.squad/decisions/inbox/boromir-pr9-review-fixes.md |
Replaced the inbox decision draft with a tombstone indicating it has been merged. |
.squad/decisions.md |
Renumbered decisions and added Decision #4 documenting CI workflow conventions. |
mpaulosky
added a commit
that referenced
this pull request
Apr 19, 2026
- routing.md: Add Guardrails #9 (Gimli parallel), #10 (no-verify prohibition), #11 (rubber duck for new patterns); strengthen Rule #6 to name Gimli+Frodo+Pippin - ceremonies.md: Add Feature Work Kickoff ceremony; harden Retrospective with coverage-gate trigger and closure requirement - pre-push-process.md: Add hard block on git push --no-verify at top of file with SDK mismatch fix instructions - pr-merge-process.md: Step 3 now explicitly checks coverage gate (not just tests passing); adds 'Tests authored' gate for Gimli coverage - gimli/charter.md: Fix Critical Rule #1 paths from IssueTracker to MyBlog (tests/Unit.Tests, tests/Architecture.Tests); add coverage gate (89%); add Rule #9 enforcing parallel spawn Closes #68 (retrospective action items) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the decisions inbox — merges
boromir-pr9-review-fixes.mdinto.squad/decisions.mdas Decision #4: CI Workflow Conventions.Working as Scribe (Documentation & Knowledge Management)
What changed
.squad/decisions.md— Added Decision refactor: consolidate common @using directives into _Imports.razor files #4 with 5 CI conventions from PR feat(ci): Phase 3-4 — parallel tests, GitVersion, hotfix workflow, branch protection #9 Copilot review.squad/decisions/inbox/boromir-pr9-review-fixes.md— Marked as merged (tombstone comment)Decision #4 covers
global-json-file: global.jsoninsetup-dotnetnuGetVersionfor/p:Versionin dotnet build (notassemblySemVer)squad-test.ymlmust only trigger onpull_request, notpushcontinue-on-error: trueThese conventions apply to all future workflow files.