Skip to content

docs(squad): enforce sprint context on all issue creation (#66)#67

Merged
mpaulosky merged 2 commits into
devfrom
squad/66-enforce-sprint-context
Apr 19, 2026
Merged

docs(squad): enforce sprint context on all issue creation (#66)#67
mpaulosky merged 2 commits into
devfrom
squad/66-enforce-sprint-context

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Closes #66

Working as Ralph (Meta / squad maintenance)

Summary

Strengthens three squad process documents so that no issue can exist without a sprint assignment and every issue title carries the [Sprint N] prefix.

Changes

Testing

Squad process documents — no build or test suite applies.

- sprint-planning.md: strengthen Hard Gate to require [Sprint N] title prefix
  and milestone before any branch; add 2 new anti-patterns
- sprint-planning.md: Step 3 gains mandatory-format table
- routing.md: Guardrails #1 and #8 require milestone + sprint prefix on every issue
- issue-lifecycle.md: add mandatory issue format block to GitHub section

Closes #66

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 19, 2026 21:44
@github-actions

github-actions Bot commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Summary
Generated on: 04/19/2026 - 22:04:33
Coverage date: 04/19/2026 - 22:03:59 - 04/19/2026 - 22:04:18
Parser: MultiReport (4x Cobertura)
Assemblies: 4
Classes: 35
Files: 34
Line coverage: 64.3% (474 of 737)
Covered lines: 474
Uncovered lines: 263
Coverable lines: 737
Total lines: 2069
Branch coverage: 64% (169 of 264)
Covered branches: 169
Total branches: 264
Method coverage: Feature is only available for sponsors
Tag: 63_24640206800

Coverage

AppHost - 0%
Name Line Branch
AppHost 0% ****
Program 0%
Domain - 93.4%
Name Line Branch
Domain 93.4% 50%
Domain.Abstractions.Result 95% 50%
Domain.Abstractions.Result`1 75% 50%
MyBlog.Domain.Entities.BlogPost 100%
ServiceDefaults - 0%
Name Line Branch
ServiceDefaults 0% 0%
Microsoft.Extensions.Hosting.Extensions 0% 0%
Web - 68.1%
Name Line Branch
Web 68.1% 69%
MyBlog.Web.Components.Layout.MainLayout 100%
MyBlog.Web.Components.Layout.NavMenu 82.8% 71.4%
MyBlog.Web.Components.Pages.Error 100% 75%
MyBlog.Web.Components.Routes 0% 0%
MyBlog.Web.Components.Shared.RedirectToLogin 100%
MyBlog.Web.Data.BlogDbContext 100%
MyBlog.Web.Data.BlogPostDto 100%
MyBlog.Web.Data.BlogPostMappings 100%
MyBlog.Web.Data.MongoDbBlogPostRepository 100% 100%
MyBlog.Web.Features.BlogPosts.Create.Create 75% 50%
MyBlog.Web.Features.BlogPosts.Create.CreateBlogPostCommand 100%
MyBlog.Web.Features.BlogPosts.Create.CreateBlogPostHandler 100%
MyBlog.Web.Features.BlogPosts.Delete.ConfirmDeleteDialog 100% 100%
MyBlog.Web.Features.BlogPosts.Delete.DeleteBlogPostCommand 100%
MyBlog.Web.Features.BlogPosts.Delete.DeleteBlogPostHandler 100%
MyBlog.Web.Features.BlogPosts.Edit.Edit 88% 75%
MyBlog.Web.Features.BlogPosts.Edit.EditBlogPostCommand 100%
MyBlog.Web.Features.BlogPosts.Edit.EditBlogPostHandler 84% 90%
MyBlog.Web.Features.BlogPosts.Edit.GetBlogPostByIdQuery 100%
MyBlog.Web.Features.BlogPosts.List.GetBlogPostsHandler 100% 100%
MyBlog.Web.Features.BlogPosts.List.Index 86.8% 84.6%
MyBlog.Web.Features.UserManagement.AssignRoleCommand 100%
MyBlog.Web.Features.UserManagement.ManageRoles 90.4% 75%
MyBlog.Web.Features.UserManagement.Profile 97.2% 82%
MyBlog.Web.Features.UserManagement.RemoveRoleCommand 100%
MyBlog.Web.Features.UserManagement.RoleDto 100%
MyBlog.Web.Features.UserManagement.UserManagementHandler 0% 0%
MyBlog.Web.Features.UserManagement.UserWithRolesDto 100%
MyBlog.Web.Security.RoleClaimsHelper 91.8% 91.1%
Program 0% 0%

- routing.md: Add Guardrails #9 (Gimli parallel), #10 (no-verify prohibition),
  #11 (rubber duck for new patterns); strengthen Rule #6 to name Gimli+Frodo+Pippin
- ceremonies.md: Add Feature Work Kickoff ceremony; harden Retrospective with
  coverage-gate trigger and closure requirement
- pre-push-process.md: Add hard block on git push --no-verify at top of file
  with SDK mismatch fix instructions
- pr-merge-process.md: Step 3 now explicitly checks coverage gate (not just
  tests passing); adds 'Tests authored' gate for Gimli coverage
- gimli/charter.md: Fix Critical Rule #1 paths from IssueTracker to MyBlog
  (tests/Unit.Tests, tests/Architecture.Tests); add coverage gate (89%);
  add Rule #9 enforcing parallel spawn

Closes #68 (retrospective action items)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mpaulosky

Copy link
Copy Markdown
Owner Author

Squad Retrospective Additions — PR #58 Quality Gate Hardening

This PR now includes the governance hardening from the PR #58 retrospective in addition to the original sprint-context enforcement. 5 files updated:

Changes added in this push:

File What Changed
routing.md Guardrails #9 (Gimli parallel spawn), #10 (--no-verify hard prohibition), #11 (rubber duck for new patterns); Rule #6 strengthened to name Gimli+Frodo+Pippin
ceremonies.md Feature Work Kickoff ceremony added (spawn Gimli+Frodo before coding); Retrospective hardened with coverage-gate trigger
pre-push-process.md Hard ⛔ block on git push --no-verify at top of file with SDK mismatch fix instructions
pr-merge-process.md Step 3 now checks coverage gate explicitly; new "Tests authored" gate for Gimli coverage
gimli/charter.md Critical Rule #1 corrected from IssueTracker paths → MyBlog paths; 89% coverage gate added; Rule #9 enforcing parallel spawn

Root cause addressed:

PR #58 failed CI on coverage (83.68% < 89% threshold). All tests passed but Domain CQRS handlers had no unit tests. --no-verify was used due to SDK mismatch (10.0.106 vs 10.0.202 pinned in global.json). These governance changes prevent recurrence.

Issue #68 (raise Domain coverage) remains open for Gandalf/Gimli to address the actual test gap.

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Complexity Health
Domain 0% 0% 38
Web 0% 0% 334
ServiceDefaults 0% 0% 18
Domain 0% 0% 38
Web 0% 0% 334
ServiceDefaults 0% 0% 18
AppHost 0% 100% 1
Domain 43% 0% 38
Web 5% 1% 334
ServiceDefaults 0% 0% 18
AppHost 0% 100% 1
Domain 43% 0% 38
Web 5% 1% 334
ServiceDefaults 0% 0% 18
Domain 93% 50% 38
Web 63% 65% 334
ServiceDefaults 0% 0% 18
Domain 93% 50% 38
Web 63% 65% 334
ServiceDefaults 0% 0% 18
Summary 23% (1000 / 4382) 21% (338 / 1644) 2342

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mpaulosky
mpaulosky merged commit 9e18a8e into dev Apr 19, 2026
5 checks passed
@mpaulosky
mpaulosky deleted the squad/66-enforce-sprint-context branch April 19, 2026 22:08
mpaulosky added a commit that referenced this pull request Apr 19, 2026
Merges governance enforcement updates from PR #67 into sprint branch.
Squad documentation conflicts resolved by keeping the more comprehensive
HEAD version (sprint enforcement) and incorporating net-new content from dev.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sprint 3] Enforce sprint context on all issue creation

2 participants