chore: remove Weather and Counter template leftovers#6
Merged
Conversation
- Moved all decision files from .squad/decisions/inbox/ into decisions.md - Removed empty inbox directory - Added CI workflow session documentation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Deleted Weather and Counter Blazor pages/components (Blazor template leftovers) - Removed obsolete unit tests for Weather and Counter components - All builds verified (Web project and Unit.Tests project) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Added learnings from Weather/Counter cleanup to history.md - Created decision record in inbox Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes leftover Blazor template artifacts (Weather/Counter pages and their smoke tests) from the MyBlog app, but also includes a large unrelated documentation merge into squad decisions.
Changes:
- Deleted the default template pages
Counter.razorandWeather.razor. - Removed the corresponding bUnit smoke tests from
RazorSmokeTests.cs. - Updated committed Tailwind output CSS (likely due to content-scan changes after page deletions).
- Appended a large “Merged from Inbox” block into
.squad/decisions/decisions.mdand added a related entry to Legolas agent history.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit.Tests/Components/RazorSmokeTests.cs | Removes obsolete Counter/Weather smoke tests. |
| src/Web/wwwroot/css/tailwind.css | Regenerated compiled Tailwind CSS output after template page removal. |
| src/Web/Components/Pages/Weather.razor | Deleted template Weather page. |
| src/Web/Components/Pages/Counter.razor | Deleted template Counter page. |
| .squad/decisions/decisions.md | Adds a large merged decision log block (appears unrelated to Weather/Counter removal). |
| .squad/agents/legolas/history.md | Documents the template cleanup in agent history. |
Comment on lines
+269
to
+276
| --- | ||
| ## Additional Decisions (Merged from Inbox) | ||
|
|
||
|
|
||
| ### 2025-01-23T18:30:00Z: Optimistic Concurrency — Domain Layer | ||
| **By:** Aragorn | ||
| **What:** Added Version field to BlogPost entity (private setter, incremented in Update()). Configured IsConcurrencyToken() in BlogDbContext.OnModelCreating for MongoDB EF Core optimistic concurrency. | ||
| **Why:** Training project demonstrating the pattern. ResultErrorCode.Concurrency was pre-existing but unused. |
There was a problem hiding this comment.
This PR is described as removing the template Weather/Counter pages, but this diff also appends a very large block of unrelated decision log content ("Additional Decisions (Merged from Inbox)", Tailwind review, CI/CD notes, Auth0 notes, etc.). Please split these documentation/decision merges into a separate PR (or drop them from this PR) so the change set matches the stated scope and remains reviewable.
mpaulosky
added a commit
that referenced
this pull request
Apr 18, 2026
- Merge decision inbox file into .squad/decisions.md with: - CI workflow security review (PR #5) - Template cleanup security review (PR #6) - Copyright header decision (PR #7) - Delete gandalf-pr5-pr6-merged.md from decisions/inbox/ - Add orchestration log with full PR merge details - Add session log summarizing board clear status PRs #5 (CI workflow), #6 (template cleanup), #7 (copyright headers) all merged to main by Gandalf. All 74 tests passing, 91.64% coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mpaulosky
added a commit
that referenced
this pull request
Apr 19, 2026
- routing.md: Add Guardrails #9 (Gimli parallel), #10 (no-verify prohibition), #11 (rubber duck for new patterns); strengthen Rule #6 to name Gimli+Frodo+Pippin - ceremonies.md: Add Feature Work Kickoff ceremony; harden Retrospective with coverage-gate trigger and closure requirement - pre-push-process.md: Add hard block on git push --no-verify at top of file with SDK mismatch fix instructions - pr-merge-process.md: Step 3 now explicitly checks coverage gate (not just tests passing); adds 'Tests authored' gate for Gimli coverage - gimli/charter.md: Fix Critical Rule #1 paths from IssueTracker to MyBlog (tests/Unit.Tests, tests/Architecture.Tests); add coverage gate (89%); add Rule #9 enforcing parallel spawn Closes #68 (retrospective action items) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 19, 2026
Closed
mpaulosky
added a commit
that referenced
this pull request
Apr 26, 2026
## Summary Migrates Architecture.Tests test methods to xUnit v3 API conventions, following the Sprint 7 Domain.Tests pilot pattern. Closes #178 **Working as Gimli (Tester)** --- ## What Changed All 4 test files updated with proper xUnit v3 migration conventions: | File | Tests | Change | |------|-------|--------| | `DomainLayerTests.cs` | 4 | AAA comments + extract `assembly` variable for clean Arrange/Act split | | `VsaLayerTests.cs` | 3 | AAA comments + extract `domainAssembly` variable | | `ThemeLayerTests.cs` | 2 | AAA comments | | `CachingLayerTests.cs` | 2 | AAA comments | **Total: 11 tests migrated** ## xUnit v3 API Observations - `[Fact]` attribute is **identical** in xUnit v2 and v3 — no attribute changes required - No async/await patterns in architecture tests — no lifecycle changes needed - No `IClassFixture` / `ICollectionFixture` — stateless tests, no collection changes needed - FluentAssertions `.Should()` works unchanged with xUnit v3 - Parallelization via `xunit.runner.json` was already configured in Wave 1 (#182) ## Pattern Reference (Sprint 7 Domain.Tests Pilot) Followed the same approach as the Sprint 7 Domain.Tests migration: - xUnit v3 meta-package via `<PackageReference Include="xunit.v3"/>` ✅ (Wave 1) - `xunit.runner.json` with `parallelizeAssembly: true` ✅ (Wave 1) - Gimli Rule #3: AAA comments on all test methods ✅ (this PR) - Gimli Rule #6: File headers present on all files ✅ (pre-existing) ## Test Results ``` Passed! - Failed: 0, Passed: 11, Skipped: 0, Total: 11 — Architecture.Tests.dll Passed! - Failed: 0, Passed: 42, Skipped: 0, Total: 42 — Domain.Tests.dll ``` Zero failures. Ready to merge to `sprint/8-xunit-v3-pilot`. Co-authored-by: Boromir <boromir@squad.dev> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Blazor default template pages (Weather, Counter) and their related tests that are not relevant to the MyBlog application.
Changes
Test results
✅ All existing tests passing after cleanup:
Requested by mpaulosky.