Skip to content

If path is not set or empty do not run any media scanner#7691

Merged
AndyScherzinger merged 1 commit into
masterfrom
fixMediaScannerWithNoPath
Dec 22, 2020
Merged

If path is not set or empty do not run any media scanner#7691
AndyScherzinger merged 1 commit into
masterfrom
fixMediaScannerWithNoPath

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Dec 18, 2020 •
edited by AndyScherzinger
Loading

Copy link
Copy Markdown
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@tobiasKaminsky
If path is not set or empty do not run any media scanner
e6a7d12 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky

tobiasKaminsky commented Dec 18, 2020

Copy link
Copy Markdown
Member Author

Can you test QA version?
Some of #5039
@hammy1988 as you had a problem with it (#1350)

@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 18, 2020
Closed
@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7691.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

Blue-Dark-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/148-IT-stable-07-04

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

Blue-Dark-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7691-Screenshot-Blue-Dark-07-04

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/148-IT-master-07-05

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

White-Dark-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

Codacy

Lint

TypemasterPR
Warnings271271
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings52
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings41
Dodgy code Warnings99
Total310

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings52
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings41
Dodgy code Warnings99
Total310

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

White-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

White-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7691-Screenshot-White-Light-07-07

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

Blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

Blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7691-Screenshot-Blue-Light-07-07

@nextcloud-android-bot

nextcloud-android-bot commented Dec 18, 2020

Copy link
Copy Markdown
Collaborator

White-Dark-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7691-Screenshot-White-Dark-07-06

@AndyScherzinger
AndyScherzinger merged commit 01bfcae into master Dec 22, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the fixMediaScannerWithNoPath branch December 22, 2020 08:13
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.15.0 milestone Dec 22, 2020
@hammy1988

hammy1988 commented Dec 22, 2020

Copy link
Copy Markdown

Can you test QA version?
Some of #5039
@hammy1988 as you had a problem with it (#1350)

Sorry! Haven't been home until now.
I tested the APK 7691. It was a little bit tricky, because after I entered my credential the app immediately crashed (for a second i can read "loading ..." on the screen).
But i cloud setup the sync anyway. And that worked fine!

InkedInkedSVID_20201222_205058_2.mp4

@AndyScherzinger AndyScherzinger mentioned this pull request Jan 5, 2021
Closed
1 task
thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021
@AndyScherzinger
Merge pull request nextcloud#7691 from nextcloud/fixMediaScannerWithN…
6fe45cd 
…oPath

If path is not set or empty do not run any media scanner
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasKaminsky @nextcloud-android-bot @hammy1988 @AndyScherzinger