test for #5039#7504
Closed
tobiasKaminsky wants to merge 1 commit into
Closed
Conversation
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-3.14)
|
|
APK not available. |
AndyScherzinger
marked this pull request as ready for review
December 7, 2020 20:15
AndyScherzinger
force-pushed
the
testFor5039
branch
from
December 7, 2020 20:18
6986120 to
e4f67df
Compare
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/58.apk |
Member
|
@AndoKarim I just did a rebase, so here is the latest APK based on this PR: #7504 (comment) |
Collaborator
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/58-IT-stable-20-44 |
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-3.14)
|
Member
|
@tobiasKaminsky I think this PR is obsolete and has been replaced by: #7694 and #7691 |
AndyScherzinger
added
the
needs info
Member
|
Fixed on master already and shipped so closing since 3.14. is obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5039
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests