Skip to content

Stable-3.14: If path is not set or empty do not run any media scanner#7694

Merged
AndyScherzinger merged 1 commit into
stable-3.14from
backport-7691
Dec 22, 2020
Merged

Stable-3.14: If path is not set or empty do not run any media scanner#7694
AndyScherzinger merged 1 commit into
stable-3.14from
backport-7691

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Dec 18, 2020

Copy link
Copy Markdown
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.14.2 milestone Dec 18, 2020
@tobiasKaminsky tobiasKaminsky changed the title If path is not set or empty do not run any media scanner Stable-3.14: If path is not set or empty do not run any media scanner Dec 18, 2020
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/155.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Blue-Dark-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.14PR
Warnings307307
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings52
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings41
Dodgy code Warnings100
Total311

SpotBugs (stable-3.14)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings52
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings73
Security Warnings41
Dodgy code Warnings100
Total311

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@AndyScherzinger

AndyScherzinger commented Dec 18, 2020

Copy link
Copy Markdown
Member

LGTM

@AndyScherzinger
AndyScherzinger merged commit b5db686 into stable-3.14 Dec 22, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the backport-7691 branch December 22, 2020 08:15
@AndyScherzinger AndyScherzinger linked an issue Dec 22, 2020 that may be closed by this pull request
@AndyScherzinger AndyScherzinger mentioned this pull request Jan 5, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ringtones disappear from sounds and tones

3 participants