[SE-3248] Add progress_video event and update tests - #256
Merged
toxinu merged 1 commit intoSep 25, 2020
Conversation
nizarmah
approved these changes
Sep 25, 2020
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
👍
- I tested this by playing a video and making sure the events run certain functionality
- I read through the code
-
I checked for accessibility issues - Includes documentation
-
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
Jira ticket: SE-3248 Upstream pull request: openedx#25038
toxinu
force-pushed
the
toxinu/se-3248-video-player-events
branch
from
September 25, 2020 09:52
5f6f936 to
ab23140
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is about adding new events to video player about watching progression.
Upstream pull request: edx/edx-platform#25038
JIRA tickets: SE-3248
Sandbox URL:
Sandbox is being provisioned.
Testing instructions:
Reviewers