[SE-3248] Update video progression events to 5-range instead of decade - #266
Merged
toxinu merged 1 commit intoOct 2, 2020
Merged
Conversation
toxinu
force-pushed
the
toxinu/se-3248-video-player-events
branch
from
October 1, 2020 05:40
fb4f29a to
ca04a58
Compare
nizarmah
approved these changes
Oct 1, 2020
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
👍
- I tested this: followed testing instructions
- I read through the code
-
I checked for accessibility issues - Includes documentation
-
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
@toxinu I tested the changes on the following URLs:
Can you please update the URLs in the PR description to the ones above?
toxinu
added a commit
that referenced
this pull request
Oct 2, 2020
…vents [SE-3248] Update video progression events to 5-range instead of decade
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up merge request (previous one #256) in order to send video progress every 5 percents instead of 10 as Autodesk.
Upstream merge request: edx/edx-platform#25038
We will need to cherry-pick this change into the Autodesk special branch as well.
JIRA tickets: SE-3248
Sandbox URL:
Sandbox is being provisioned.
Testing instructions:
Reviewers