[SE-3248] Revert progress_video event changes - #341
Merged
Conversation
toxinu
changed the title
progress_video event changes
nizarmah
approved these changes
Apr 20, 2021
nizarmah
left a comment
nizarmah
left a comment
There was a problem hiding this comment.
👍
- I tested this by diffing the changes against the pull requests mentioned in the commit
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
toxinu
changed the base branch from
opencraft-release/koa.2a
to
opencraft-release/koa.3
April 23, 2021 05:50
toxinu
changed the base branch from
opencraft-release/koa.3
to
opencraft-release/koa.2a
April 23, 2021 05:51
toxinu
changed the base branch from
opencraft-release/koa.2a
to
autodesk-release/koa.3
April 28, 2021 01:53
toxinu
force-pushed
the
toxinu/revert-se-3248
branch
from
April 28, 2021 01:55
c0a8488 to
b81a790
Compare
toxinu
changed the base branch from
autodesk-release/koa.3
to
opencraft-release/koa.3
April 28, 2021 01:56
toxinu
force-pushed
the
toxinu/revert-se-3248
branch
from
April 28, 2021 01:56
b81a790 to
95cb83b
Compare
toxinu
force-pushed
the
toxinu/revert-se-3248
branch
from
April 30, 2021 02:51
95cb83b to
b0054b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is about reverting #256 and #266 since we won't merge those into
upstream(https://github.com/edx/edx-platform/pull/25038).Jira ticket: SE-3248
Testing instructions: Manually check that the changes have been reverted by doing a diff.
Reviewers: @nizarmah