Rename values in SiteConfiguration (2/3) attempt #2 - #23214
Merged
pwnage101 merged 2 commits intoFeb 27, 2020
Merged
Conversation
This reverts commit b85aa4b.
pwnage101
force-pushed
the
pwnage101/rename_site_configuration_siteconfiguration_values_2.1
branch
from
February 26, 2020 19:44
eb7d61c to
a1e968d
Compare
This commit fixes an issue originally in 3541643 where an instance method on a model was missing in a migration. The problem was that Django is smarter than we thought, and is somehow able to construct an older version of the model before the commit, where there was no such method. The solution is just to pull the method out of the model. DENG-18
pwnage101
force-pushed
the
pwnage101/rename_site_configuration_siteconfiguration_values_2.1
branch
from
February 26, 2020 19:44
a1e968d to
3400326
Compare
bmedx
approved these changes
Feb 26, 2020
bmedx
left a comment
bmedx
left a comment
Contributor
There was a problem hiding this comment.
👍 Sorry I missed that first time around :/
|
Your PR has finished running tests. There were no failures. |
doctoryes
approved these changes
Feb 26, 2020
pwnage101
deleted the
pwnage101/rename_site_configuration_siteconfiguration_values_2.1
branch
February 27, 2020 15:34
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time, I tested actually running migrations from manage.py lms migrate in devstack, not just copy+pasting the code into a python shell.
DENG-18