Revert "Rename values in SiteConfiguration (2/3) attempt #2" - #23224
Merged
pwnage101 merged 1 commit intoFeb 27, 2020
Merged
Conversation
pwnage101
requested review from
a team,
HassanJaveed84,
bmedx,
brianhw,
doctoryes,
estute,
hunytalk and
macdiesel
February 27, 2020 18:26
|
Your PR has finished running tests. There were no failures. |
pwnage101
deleted the
revert-23214-pwnage101/rename_site_configuration_siteconfiguration_values_2.1
branch
February 27, 2020 18:58
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts edx/edx-platform#23214
The same migration failed again, but this time a different reason. JSONDecodeError on the site_values column in the history table, which apparently did not inherit the same default value as the non-history table.