Revert "Revert "Rename values in SiteConfiguration (2/3) attempt #2"" (attempt #3) - #23306
Merged
pwnage101 merged 1 commit intoMar 5, 2020
Conversation
pwnage101
changed the title
pwnage101
requested review from
HassanJaveed84,
bmedx,
brianhw,
doctoryes,
estute,
hunytalk and
macdiesel
March 4, 2020 17:48
hunytalk
approved these changes
Mar 4, 2020
pwnage101
force-pushed
the
pwnage101/deng-18-rename_site_configuration_siteconfiguration_values_2.3
branch
from
March 4, 2020 18:48
aee9d74 to
a18ece1
Compare
This reverts commit e6f58b6. This is our third (3rd!) attempt to deploy stage 2 of this column rename.
pwnage101
force-pushed
the
pwnage101/deng-18-rename_site_configuration_siteconfiguration_values_2.3
branch
from
March 4, 2020 19:53
a18ece1 to
d428f75
Compare
|
Your PR has finished running tests. There were no failures. |
pwnage101
deleted the
pwnage101/deng-18-rename_site_configuration_siteconfiguration_values_2.3
branch
March 5, 2020 14:35
pwnage101
referenced
this pull request
in openedx-unsupported/devstack
Mar 5, 2020
pwnage101
referenced
this pull request
in openedx-unsupported/devstack
Mar 5, 2020
pwnage101
referenced
this pull request
in openedx-unsupported/devstack
Mar 5, 2020
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e6f58b6.
This is our third (3rd!) attempt to deploy stage 2 of this column rename.
Just as a quick reminder for reviewers, this PR does the following things:
@skipto the unit test that checks that migrations are in sync (test_migrations_are_in_sync).