AO3-6531 Fix comment decorator 500 error for orphaned comments by pmonfort · Pull Request #5719 · otwcode/otwarchive

pmonfort · 2026-04-10T02:35:16Z

Pull Request Checklist

Have you read "How to write the perfect pull request"?
Have you read the contributing guidelines?
Have you added tests for any changed functionality?
Have you added the Jira issue number
as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
Do you have fewer than 5 pull requests already open? If not, please wait
until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6531

Purpose

Fixes a 500 error in CommentDecorator.from_thread_ids caused by orphaned comments — replies whose parent comment was physically removed from
the database (via .delete) rather than soft-deleted.

When building the comment tree, the decorator looks up each reply's parent in a hash by commentable_id. If the parent was physically deleted,
the lookup returns nil, causing a NoMethodError. The fix adds a nil check so that orphaned replies are silently skipped when building the
tree, rather than crashing the page.

Additionally, this PR includes a rake task After:create_placeholders_for_orphaned_comments that finds all orphaned comments in the
database and creates soft-deleted placeholder comments in their place. The task:

Uses a LEFT JOIN to efficiently find comments whose parent no longer exists
Processes orphans top-down using the nested set (threaded_left) to handle cases where multiple comments were deleted in the same branch
Creates each placeholder as a child of the closest existing ancestor, preserving the tree structure

Testing Instructions

Create a comment thread with at least 3 levels (root → reply → nested reply)
Physically delete the middle comment from the database (e.g., Comment.find(id).delete)
Visit the page that displays the thread
Verify no 500 error occurs and the root comment still displays
Run the rake task: bundle exec rake After:create_placeholders_for_orphaned_comments
Verify a soft-deleted placeholder was created for the deleted comment
Visit the thread again and verify the placeholder appears as "[deleted comment]"

Credit

Pablo Monfort (he/him)

…cally deleted

brianjaustin

Just one naming thing, otherwise looking good! (I've approved already because I don't think a small nitpick is blocking either way)

…ble_ids.Suggested by brianjaustin.

…de#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin.

AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment

AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment

AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment Revert AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) Try to revert unintended change Revert Add trailing whitespace Try to name and use variable on same line

AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 Fix the order of en.yml

github-actions Bot added the Awaiting Review label Apr 10, 2026

AO3-6531 Fix comment decorator 500 error when parent comment is physi…

a6b8fe4

…cally deleted

pmonfort force-pushed the AO3-6531-fix-comment-decorator-500 branch from f37f8de to a6b8fe4 Compare April 10, 2026 02:38

brianjaustin self-requested a review April 11, 2026 20:05

pmonfort force-pushed the AO3-6531-fix-comment-decorator-500 branch 3 times, most recently from 3fb5cde to 50c3d3e Compare April 12, 2026 19:27

AO3-6531 Add rake task to create placeholders for orphaned comments

c4f3b3f

pmonfort force-pushed the AO3-6531-fix-comment-decorator-500 branch from 50c3d3e to c4f3b3f Compare April 13, 2026 00:31

brianjaustin approved these changes Apr 13, 2026

View reviewed changes

Comment thread lib/tasks/after_tasks.rake Outdated

brianjaustin added Reviewed: Ready to Merge and removed Awaiting Review labels Apr 13, 2026

AO3-6531 Rename orphaned_commentable_ids variable to missing_commenta…

9d458c5

…ble_ids.Suggested by brianjaustin.

pmonfort force-pushed the AO3-6531-fix-comment-decorator-500 branch from 6645ea2 to 9d458c5 Compare April 13, 2026 12:49

Merge branch 'master' into AO3-6531-fix-comment-decorator-500

cf69cd8

brianjaustin merged commit 9e7932b into otwcode:master Apr 14, 2026
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AO3-6531 Fix comment decorator 500 error for orphaned comments#5719

AO3-6531 Fix comment decorator 500 error for orphaned comments#5719
brianjaustin merged 4 commits intootwcode:masterfrom
pmonfort:AO3-6531-fix-comment-decorator-500

pmonfort commented Apr 10, 2026 •

edited

Loading

Uh oh!

brianjaustin left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pmonfort commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Issue

Purpose

Testing Instructions

Credit

Uh oh!

brianjaustin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pmonfort commented Apr 10, 2026 •

edited

Loading