AO3-6531 Remove after task for placeholder comments#5740
Merged
Bilka2 merged 1 commit intootwcode:masterfrom Apr 17, 2026
Merged
AO3-6531 Remove after task for placeholder comments#5740Bilka2 merged 1 commit intootwcode:masterfrom
Bilka2 merged 1 commit intootwcode:masterfrom
Conversation
Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live.
brianjaustin
added
the
Priority: High - Broken on Test
Bilka2
approved these changes
Apr 17, 2026
jmalark
pushed a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live.
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment Revert AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) Try to revert unintended change Revert Add trailing whitespace Try to name and use variable on same line
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 20, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 Fix the order of en.yml
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 22, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 Fix the order of en.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6531
Purpose
Removes a rake task that we should not run on production due to potential thread weirdness; the fix for the 500 error is still here, which is more important.
References
https://otwarchive.atlassian.net/browse/AO3-6531?focusedCommentId=380383
Credit
What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?
Brian Austin (they/he)