AO3-6531 Fix create_placeholders_for_orphaned_comments task 500#5736
Merged
sarken merged 2 commits intootwcode:masterfrom Apr 15, 2026
Merged
AO3-6531 Fix create_placeholders_for_orphaned_comments task 500#5736sarken merged 2 commits intootwcode:masterfrom
sarken merged 2 commits intootwcode:masterfrom
Conversation
pmonfort
force-pushed
the
AO3-6531-fix-comment-decorator-500
branch
from
a84d261 to
64dd9ba
Compare
sarken
changed the title
sarken
added
the
Priority: High - Broken on Test
sarken
approved these changes
Apr 15, 2026
jmalark
pushed a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
…ode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 19, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-7378 Updates for code review AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 add double trailing whitespace to try to get it to let me push whitespace changes after settings changes AO3-7378 Add trailing new line AO3-7378 Get my local back to just one line of trailing whitespace AO3-7378 Still trying to get trailing whitespace settings to cooperate AO3-7378 Trailing whitespace adjustment Revert AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) Try to revert unintended change Revert Add trailing whitespace Try to name and use variable on same line
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 20, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 Fix the order of en.yml
jmalark
added a commit
to jmalark/otwarchive
that referenced
this pull request
Apr 22, 2026
AO3-6229 Add static 404 error page (otwcode#5711) AO3-6531 Fix comment decorator 500 error for orphaned comments (otwcode#5719) * AO3-6531 Fix comment decorator 500 error when parent comment is physically deleted * AO3-6531 Add rake task to create placeholders for orphaned comments * AO3-6531 Rename orphaned_commentable_ids variable to missing_commentable_ids.Suggested by brianjaustin. AO3-6531 Fix create_placeholders_for_orphaned_comments task 500 (otwcode#5736) * AO3-6531 - Add spec for orphaned comment with nil threaded_left * AO3-6531 - Handle nil threaded_left in orphaned comment placeholder task AO3-7381 Update Devise to 5.0.3 (otwcode#5727) AO3-6531 Remove after task for placeholder comments (otwcode#5740) Per comments on the related ticket, this could lead to weird behaviour. Pulling this out so the fix for the most critical part can go live. AO3-7080 Fix suspended and banned user check (otwcode#5741) AO3-7378 Fix the order of en.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-6531
Purpose
Fixes an
ArgumentError: comparison of NilClass with 2 failedcrash in theAfter:create_placeholders_for_orphaned_commentsraketask when orphaned comments have
nilvalues forthreaded_left.Changes:
filter_mapinstead ofmapto skip entries where no orphan comment exists for a givenmissing_id.|| 0fallback insort_by!so comments withnilthreaded_leftdon't crash the comparison.raisewithputs+nextwhen the parent comment cannot be determined, allowing the task to continue processing remaining comments instead of aborting.Testing Instructions
After:create_placeholders_for_orphaned_commentson a database that contains orphaned comments withnilthreaded_leftvalues.threaded_leftvalues still get placeholders created correctly.bundle exec rspec spec/lib/tasks/after_tasks.rake_spec.rb -e "when an orphaned comment has nil threaded_left"References
This fix addresses the error encountered when running the rake task on staging, reported by @brianjaustin.
Credit
Pablo Monfort (he/him)