Skip to content

Move user creation without skeleton to core#730

Merged
phil-davis merged 2 commits into
masterfrom
move-user-creation-without-skeleton-to-core
May 31, 2019
Merged

Move user creation without skeleton to core#730
phil-davis merged 2 commits into
masterfrom
move-user-creation-without-skeleton-to-core

Conversation

@paurakhsharma

@paurakhsharma paurakhsharma commented May 29, 2019

Copy link
Copy Markdown
Contributor

Description

Related Issue

owncloud/QA#621

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

📓 This will only pass after owncloud/core#35355 is merged.

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will fail currently as this requires owncloud/core#35355 to be merged and available on the qa-tarball. After that, this could be merged.

@individual-it individual-it force-pushed the move-user-creation-without-skeleton-to-core branch from fc7eb08 to 3305110 Compare May 30, 2019 03:20
@codecov

codecov Bot commented May 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #730   +/-   ##
=========================================
  Coverage     83.87%   83.87%           
  Complexity      494      494           
=========================================
  Files            45       45           
  Lines          1798     1798           
=========================================
  Hits           1508     1508           
  Misses          290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4cbed...3305110. Read the comment docs.

@codecov

codecov Bot commented May 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #730   +/-   ##
=========================================
  Coverage     83.87%   83.87%           
  Complexity      494      494           
=========================================
  Files            45       45           
  Lines          1798     1798           
=========================================
  Hits           1508     1508           
  Misses          290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4cbed...9adcb19. Read the comment docs.

@individual-it

Copy link
Copy Markdown
Member

there is a problem in owncloud/core#35355 see owncloud/core#35355 (review)

@individual-it individual-it left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes here are good, but problem in core

@paurakhsharma

Copy link
Copy Markdown
Contributor Author

@individual-it Here is the fix: owncloud/core#35366

@phil-davis phil-davis merged commit 4834a82 into master May 31, 2019
@delete-merged-branch delete-merged-branch Bot deleted the move-user-creation-without-skeleton-to-core branch May 31, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants