Skip to content

Fix feature context undefined on provisioning.php#35366

Merged
phil-davis merged 1 commit into
masterfrom
fix-featureContext-undefined
May 30, 2019
Merged

Fix feature context undefined on provisioning.php#35366
phil-davis merged 1 commit into
masterfrom
fix-featureContext-undefined

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

#35355 introduced featureContext undefined error in drone when the step was called
on activity app.

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma

paurakhsharma commented May 30, 2019

Copy link
Copy Markdown
Contributor Author

Backport on: #35374

@codecov

codecov Bot commented May 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35366   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9789c1b...486d625. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35366   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9789c1b...486d625. Read the comment docs.

@phil-davis phil-davis merged commit 5dbfbc1 into master May 30, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix-featureContext-undefined branch May 30, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants