Skip to content

move user creation without skeleton from activity app#35355

Merged
dpakach merged 2 commits into
masterfrom
user-creation-without-skeleton
May 29, 2019
Merged

move user creation without skeleton from activity app#35355
dpakach merged 2 commits into
masterfrom
user-creation-without-skeleton

Conversation

@paurakhsharma

@paurakhsharma paurakhsharma commented May 29, 2019

Copy link
Copy Markdown
Contributor

Description

Move user creation without skeleton method from activity app to the core.

Related Issue

owncloud/QA#621

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@paurakhsharma paurakhsharma requested review from dpakach and skshetry May 29, 2019 07:43
@paurakhsharma paurakhsharma self-assigned this May 29, 2019
dpakach
dpakach reviewed May 29, 2019
View reviewed changes

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma paurakhsharma mentioned this pull request May 29, 2019
Merged
9 tasks
@codecov

codecov Bot commented May 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35355 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35355      +/-   ##
============================================
- Coverage     65.53%   65.53%   -0.01%     
  Complexity    18648    18648              
============================================
  Files          1218     1218              
  Lines         70549    70549              
  Branches       1288     1288              
============================================
- Hits          46236    46232       -4     
- Misses        23936    23940       +4     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (-0.01%) 18648 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/Connection.php 65.44% <0%> (-0.74%) 49% <0%> (ø)
lib/private/Files/View.php 84.3% <0%> (-0.31%) 398% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a1858...1d88479. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35355 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35355      +/-   ##
============================================
- Coverage     65.53%   65.53%   -0.01%     
  Complexity    18648    18648              
============================================
  Files          1218     1218              
  Lines         70549    70549              
  Branches       1288     1288              
============================================
- Hits          46236    46232       -4     
- Misses        23936    23940       +4     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (-0.01%) 18648 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/Connection.php 65.44% <0%> (-0.74%) 49% <0%> (ø)
lib/private/Files/View.php 84.3% <0%> (-0.31%) 398% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a1858...1d88479. Read the comment docs.

@codecov

codecov Bot commented May 29, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #35355 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35355   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a1858...1d88479. Read the comment docs.

@dpakach dpakach merged commit 539f376 into master May 29, 2019
@delete-merged-branch delete-merged-branch Bot deleted the user-creation-without-skeleton branch May 29, 2019 13:13
@phil-davis phil-davis mentioned this pull request May 29, 2019
Merged
@phil-davis

phil-davis commented May 29, 2019

Copy link
Copy Markdown
Contributor

Backport stable10 #35360

individual-it
individual-it reviewed May 30, 2019
View reviewed changes
Comment thread tests/acceptance/features/bootstrap/Provisioning.php
* @return void
*/
public function userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles($user) {
$this->featureContext->runOcc(["config:system:get skeletondirectory"]);

@individual-it individual-it May 30, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paurakhsharma this breaks CI in activity app

      Notice: Undefined property: FeatureContext::$featureContext in /var/www/owncloud/server/tests/acceptance/features/bootstrap/Provisioning.php line 282

see https://drone.owncloud.com/owncloud/activity/419/180

@paurakhsharma paurakhsharma mentioned this pull request May 30, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it left review comments
@phil-davis phil-davis phil-davis approved these changes
+2 more reviewers
@dpakach dpakach dpakach left review comments
@skshetry skshetry skshetry approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@paurakhsharma paurakhsharma

Labels

3 - To Review dev:acceptance-tests QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paurakhsharma @phil-davis @individual-it @skshetry @dpakach