Skip to content

Backport of #16890 to stable8 - #17033

Merged
MorrisJobke merged 1 commit into
stable8from
backport-16890-stable8
Jun 23, 2015
Merged

Backport of #16890 to stable8#17033
MorrisJobke merged 1 commit into
stable8from
backport-16890-stable8

Conversation

@blizzz

@blizzz blizzz commented Jun 18, 2015

Copy link
Copy Markdown
Contributor

the user is gone, userExists will not bring him back. But the user's folder needs to be deleted anyway

delete user test to take getHome into account to ensure it is also deleted subsequently
@ghost

ghost commented Jun 18, 2015

Copy link
Copy Markdown

🚀 Test PASSed.🚀
chuck

@jvillafanez

Copy link
Copy Markdown
Member

The user count, at least for the group, doesn't seem to be updated. The rest of the things work fine.

@blizzz

blizzz commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

The user count, at least for the group, doesn't seem to be updated.

Perhaps caching?

@jvillafanez

Copy link
Copy Markdown
Member

I doubt it. The "everyone" count updates fine, but the group count not, even after waiting more than 10 minutes.

@blizzz

blizzz commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

If the user was deleted from LDAP, it is not supposed to be counted at all anyway (no matter whether he was deleted via ownCloud or not). Or, is it about local groups?

@jvillafanez

Copy link
Copy Markdown
Member

I've checked only LDAP groups. No local groups in the system other than the admin one

@blizzz

blizzz commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

Then it is not supposed that anything changes. We do not write to LDAP and only deal with users that are already deleted from LDAP, and so should be their group memberships.

@DeepDiver1975

Copy link
Copy Markdown
Member

sounds like this has to wait until 8.0.6 ❓

@blizzz @jvillafanez

@MorrisJobke

Copy link
Copy Markdown
Contributor

Tested and works. 👍

@MorrisJobke

Copy link
Copy Markdown
Contributor

The same as #17034 (comment) applies to this PR.

@MorrisJobke

Copy link
Copy Markdown
Contributor

@jvillafanez please retest with a LDAP user, a home folder naming rule and the deletion of that folder.

@jvillafanez

Copy link
Copy Markdown
Member

👍

MorrisJobke added a commit that referenced this pull request Jun 23, 2015
@MorrisJobke
MorrisJobke merged commit dc07139 into stable8 Jun 23, 2015
@MorrisJobke
MorrisJobke deleted the backport-16890-stable8 branch June 23, 2015 14:31
@jvillafanez

Copy link
Copy Markdown
Member

@blizzz FYI, regarding the supposed bug with the user count, I didn't notice that the member list of the groups didn't get updated on its own after deleting the user; I haven't set the referencial integrity in the LDAP server (openLDAP) so the entry for the user was still in the groups. That explains why the user count didn't get updated.

Now you can sleep like a log 😄

@blizzz

blizzz commented Jun 23, 2015

Copy link
Copy Markdown
Contributor Author

super, thank you @jvillafanez

💤
🐩

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants