Adding more trashbin scenarios

[SergioBertolinSG]

Something is failing in the second scenario. The listed elements of the trashbin are less than expected and the file the case is looking for is not found.

[SergioBertolinSG]

The requests to index.php/apps/files_trashbin/ajax/list.php?dir=%2Fare not returning all the elements in the trashbin. It is having troubles with the files in subfolders.
Only happening when the files has the same name. @PVince81

[phil-davis]

There are a few "recieved" - here and further down.
s/recieved/received
Isn't English a great language ;)

[SergioBertolinSG]

Pending to be done: fixes for the two failing cases. Check if the whole suite pass after last changes.

[felixboehm]

If your suite contains tests, which point out bugs, is this a blocker for merging the tests?
Suggestion: Can you open an PR for each, containing the failing testcase, so that fixing and test come together in that PR?

[phil-davis]

The other option, if fixes are going to be some time away, is to tag the scenarios that fail with @Skip so that they are skipped in "normal" CI runs. Then in the PR that fixes the bug, also remove the @Skip tag.
(and have the script that runs tests default to ~@Skip to not run scenarios tagged to be skipped.

[SergioBertolinSG]

Failing cases in jenkins:

trashbin-new-endpoint.deleting a file in a received folder it is moved to the trashbin
trashbin-new-endpoint.trashbin can store two files with same name but different origins
trashbin-old-endpoint.deleting a file in a received folder it is moved to the trashbin
trashbin-old-endpoint.trashbin can store two files with same name but different origins
trashbin-old-endpoint.Deleting a folder into external storage moves it to the trashbin
trashbin-old-endpoint.Deleting a file into external storage moves it to the trashbin and can be restored

Pending to implement the skip label to fix this cases in a different PR.

[PVince81]

are these cases reproducible manually ? AFAIK at least storing two files with different origins should still work.

[SergioBertolinSG]

Regarding "deleting a file in a received folder it is moved to the trashbin", yes I opened it here, the problem is a missing parameter called 'extraData':

#28121

Regarding "trashbin can store two files with same name but different origins", I cannot reproduce it manually, but in the tests it always fails.

trashbin-old-endpoint.Deleting a folder into external storage moves it to the trashbin

This one is a test problem, I can fix it.

trashbin-old-endpoint.Deleting a file into external storage moves it to the trashbin and can be restored

This one has the same problem as the previous one, fixable in tests, but maybe the restoration part is affected also by the missing 'extraData' parameter bug.

[PVince81]

if manual reproduction doesn't work but automated test fails, then maybe the tests aren't doing exactly the same, or it's not using the same APIs.

[SergioBertolinSG]

Now the tests:

trashbin-new-endpoint.deleting a file in a received folder it is moved to the trashbin
trashbin-new-endpoint.trashbin can store two files with same name but different origins
trashbin-old-endpoint.deleting a file in a received folder it is moved to the trashbin
trashbin-old-endpoint.trashbin can store two files with same name but different origins

Are skipped. To be removed the "@Skip" label to run them when fixing the actual core issues.

[PVince81]

trashbin-new-endpoint.deleting a file in a received folder it is moved to the trashbin

Is this reproducible manually ? Last time I tested this manually when working on this part all worked fine.

[PVince81]

Actually both the owner trashbin and recipient trashbin should receive the file.

[SergioBertolinSG]

@PVince81 the problem is the lack of extraData field. Which makes this step to fail:
Then as "user1" the file with original path "/shared/shared_file.txt" exists in trash

The file is in the trashbin, but if it is restored it will go to the root folder instead to the original path. #28121

[PVince81]

ok

[PVince81]

Here is the fix for restoring into the wrong folder: #28196

[PVince81]

See https://github.com/owncloud/core/blob/master/apps/files_trashbin/tests/TrashbinTest.php#L639 for more restore cases to cover

[PVince81]

we still have skipped tests ?

[SergioBertolinSG]

Yes, that scenario is not related with the extraData fix.

It doesn't fail manually, but in the test it always fail. I recommend to merge this and take a look when you want. The test doesn't seem wrong, looks like a hidden bug not reproducible using the ui.

[PVince81]

hidden bug

I hate these

[PVince81]

backport?

[SergioBertolinSG]

Ok, to stable10 and others? or just stable10?

[PVince81]

as far as possible I'd say to guarantee coverage on older versions too.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.