Skip to content

Add missing entry in trash for recipient#28196

Merged
PVince81 merged 1 commit into
masterfrom
trashbin-restoretarget-recipient
Jun 28, 2017
Merged

Add missing entry in trash for recipient#28196
PVince81 merged 1 commit into
masterfrom
trashbin-restoretarget-recipient

Conversation

@PVince81

Copy link
Copy Markdown
Contributor

Description

Fix regression by properly creating user entry in trash table for shared recipient.
This used to be in the old code but got discarded by mistake.

Related Issue

Fixes #28121

Motivation and Context

We hate regressions

How Has This Been Tested?

Tested manually with steps from the ticket.
Integration tests are in another PR: #28111

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81

Copy link
Copy Markdown
Contributor Author

rebased

@jvillafanez

Copy link
Copy Markdown
Member

👍

@PVince81

Copy link
Copy Markdown
Contributor Author
21:28:10 ownCloud is not installed - only a limited number of commands are available
21:28:10 Oracle connection could not be established
21:28:10  -> ORA-01033: ORACLE initialization or shutdown in progress Check environment: ORACLE_HOME=/usr/lib/oracle/12.1/client64 ORACLE_SID= LD_LIBRARY_PATH= NLS_LANG= tnsnames.ora is not readable
21:28:10 Kill the docker 82a71b6bb7a14679c2ae62dfd3d1a96217c990f728da441f48fe2e2e92b31a05
21:28:19 82a71b6bb7a14679c2ae62dfd3d1a96217c990f728da441f48fe2e2e92b31a05
21:28:19 82a71b6bb7a14679c2ae62dfd3d1a96217c990f728da441f48fe2e2e92b31a05
21:28:19 Makefile:179: recipe for target 'test-php' failed
21:28:19 make: *** [test-php] Error 1

@PVince81 PVince81 modified the milestones: 10.1, 10.0.3 Jun 26, 2017
@SergioBertolinSG

Copy link
Copy Markdown
Contributor

I've added an specific test case for #28121 in #28111.

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

Running those skipped tests locally worked. Also manually 👍

@PVince81 PVince81 force-pushed the trashbin-restoretarget-recipient branch from 56c6603 to 53195b3 Compare June 28, 2017 12:19
@PVince81

Copy link
Copy Markdown
Contributor Author

rebased

@PVince81 PVince81 merged commit ac39c47 into master Jun 28, 2017
@PVince81 PVince81 deleted the trashbin-restoretarget-recipient branch June 28, 2017 15:13
@DeepDiver1975 DeepDiver1975 modified the milestones: 10.1, development Oct 10, 2017
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files deleted from a shared folder as recipient are restored to root folder.

4 participants