Add conditional delay to avoid same stime in int test#28310
Merged
Conversation
Should prevent the "Merging shares" test suites to fail randomly as the results order is dependent on the share time.
This was referenced Jul 5, 2017
SergioBertolinSG
approved these changes
Jul 6, 2017
This was referenced Jul 6, 2017
9 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should prevent the "Merging shares" test suites to fail randomly as the
results order is dependent on the share time.
Related Issue
None
Motivation and Context
Because we hate randomly failing tests and we already have enough trouble needing to constantly rebase for Jenkins, so we could do without this additional annoyance.
How Has This Been Tested?
Run the sharing-v1.feature tests
Screenshots (if appropriate):
Types of changes
Checklist:
@SergioBertolinSG