Skip to content

Add conditional delay to avoid same stime in int test#28310

Merged
DeepDiver1975 merged 1 commit into
masterfrom
inttest-delayshare-stime
Jul 6, 2017
Merged

Add conditional delay to avoid same stime in int test#28310
DeepDiver1975 merged 1 commit into
masterfrom
inttest-delayshare-stime

Conversation

@PVince81

@PVince81 PVince81 commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

Description

Should prevent the "Merging shares" test suites to fail randomly as the
results order is dependent on the share time.

Related Issue

None

Motivation and Context

Because we hate randomly failing tests and we already have enough trouble needing to constantly rebase for Jenkins, so we could do without this additional annoyance.

How Has This Been Tested?

Run the sharing-v1.feature tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SergioBertolinSG

Should prevent the "Merging shares" test suites to fail randomly as the
results order is dependent on the share time.
@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants