Skip to content

[Stable10] Add conditional delay to avoid same stime in int test#28314

Merged
DeepDiver1975 merged 1 commit into
stable10from
stable10-inttest-delayshare-stime
Jul 6, 2017
Merged

[Stable10] Add conditional delay to avoid same stime in int test#28314
DeepDiver1975 merged 1 commit into
stable10from
stable10-inttest-delayshare-stime

Conversation

@SergioBertolinSG

Copy link
Copy Markdown
Contributor

Should prevent the "Merging shares" test suites to fail randomly as the
results order is dependent on the share time.

Backport of #28310

@SergioBertolinSG

Copy link
Copy Markdown
Contributor Author

Required for #28268

@davitol davitol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Should prevent the "Merging shares" test suites to fail randomly as the
results order is dependent on the share time.
@SergioBertolinSG SergioBertolinSG force-pushed the stable10-inttest-delayshare-stime branch from 2f68b9c to 42a59fd Compare July 6, 2017 11:44

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

PVince81 commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

so it doesn't work :-(

sharing.Merging shares for recipient when shared from outside with group then user and recipient renames in between

@phil-davis

Copy link
Copy Markdown
Contributor

I had this example in a PR in master today, that should have been at a point past when this stuff was merged to master:
#28318 (comment)
I was a bit surprised that it had happened. When tried to rebase, my PR was already up-to-date with master, so I am pretty confident that it ran with this code.

@PVince81

PVince81 commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

This failure is bad luck. Some tests running too fast (yeah I know, surprising?). This PR was supposed to eliminate this failure by introducing a conditional delay.

@PVince81

PVince81 commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

we could maybe add a log before the sleep just to see whether it's really going there when the failure happens...

or maybe this one tests uses another code path that doesn't go there... @SergioBertolinSG mind checking ?

@DeepDiver1975 DeepDiver1975 merged commit 590d014 into stable10 Jul 6, 2017
@DeepDiver1975 DeepDiver1975 deleted the stable10-inttest-delayshare-stime branch July 6, 2017 18:16
@PVince81 PVince81 added this to the old milestone Jun 13, 2018
@lock

lock Bot commented Jul 30, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants