possibility to modify app settings through TestHelpers#29388
Conversation
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Looks good now. This will share some code between integration and UI tests for setting capabilities.
Codecov Report
@@ Coverage Diff @@
## master #29388 +/- ##
=========================================
Coverage 60.45% 60.45%
Complexity 17222 17222
=========================================
Files 1032 1032
Lines 57360 57360
=========================================
Hits 34677 34677
Misses 22683 22683Continue to review full report at Codecov.
|
1cc2d4d to
1d2b994
Compare
individual-it
changed the title
1d2b994 to
72e9a91
Compare
|
@SergioBertolinSG @davitol any comments on this? |
fc8d964 to
44d05e2
Compare
| } catch (ElementNotFoundException $e) { | ||
| PHPUnit_Framework_Assert::assertContains( | ||
| 'could not find share-with-field', | ||
| 'could not find shar', |
There was a problem hiding this comment.
@individual-it I guess you did not intend to modify this.
There was a problem hiding this comment.
I did because it can be "could not find share-with-field" or "could not find sharing button in fileRow"
it gets a further edit in #29406
There was a problem hiding this comment.
OK - I will look there for the final thing.
| $fullUrl = $this->baseUrl . "v{$this->apiVersion}.php" . $url; | ||
| $client = new Client(); | ||
| $options = []; | ||
| $fd = []; |
There was a problem hiding this comment.
What means fd? Can it have a more descriptive name?
There was a problem hiding this comment.
changed the name, made a comment and moved the data conversion to a more logical plan
44d05e2 to
6754281
Compare
6754281 to
3c6a62d
Compare
3c6a62d to
dd543da
Compare
|
@individual-it make the backport PR already so it can run CI over the weekend... |
|
backport in #29443 |
dd543da to
04622df
Compare
|
Rebased and resolved conflicts |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
Description
preparation for tests that need a specific set of preferences set. E.g. to test #29241
Motivation and Context
for some tests we need to change preferences of owncloud or specific apps
How Has This Been Tested?
run tests locally
Types of changes
Checklist: