Skip to content

UI tests for restricting the sharing - #29406

Merged
phil-davis merged 1 commit into
masterfrom
ui-tests_share_with_group_membership_only
Nov 6, 2017
Merged

UI tests for restricting the sharing#29406
phil-davis merged 1 commit into
masterfrom
ui-tests_share_with_group_membership_only

Conversation

@individual-it

Copy link
Copy Markdown
Member

Description

UI test to see if various ways of restricting the sharing options work e.g "Share with group membership only" #29241

This PR contains also the changes from #29388 because it depends on them

Related Issue

#29075

Motivation and Context

test sharing behaviour

How Has This Been Tested?

run tests locally, travis will test again

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@individual-it

Copy link
Copy Markdown
Member Author

@jvillafanez could you please check if the tests described in f0a4b4d#diff-4a8972ffadc126987f05eebd52151aec are what you have programmed
And if you can up with more sensible checks, that would be great!

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just little things.
This seems a good start to testing the sharing restrictions. After this we can easily look through the other sharing settings and make basic UI tests to confirm that other combinations work.

*/
private $savedCapabilitiesChanges = [];

/**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/readable/readable

Feature: restrict resharing

As admin
I would like to be able to forbid the sharing of a received share globaly

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/globaly/globally/

@codecov

codecov Bot commented Nov 1, 2017

Copy link
Copy Markdown

Codecov Report

Merging #29406 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29406   +/-   ##
=========================================
  Coverage     60.47%   60.47%           
  Complexity    17235    17235           
=========================================
  Files          1032     1032           
  Lines         57389    57389           
=========================================
  Hits          34707    34707           
  Misses        22682    22682

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3a485...8626ac2. Read the comment docs.

@individual-it
individual-it force-pushed the ui-tests_share_with_group_membership_only branch from f0a4b4d to 06a6844 Compare November 2, 2017 10:30
@individual-it
individual-it force-pushed the ui-tests_share_with_group_membership_only branch 4 times, most recently from f28aa0f to 76f5ebf Compare November 6, 2017 09:29
@PVince81

PVince81 commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

I suggest rebasing for CI

@jvillafanez

Copy link
Copy Markdown
Member

I think we should include tests for the case where the checkbox aren't checked. Other than that, the tests look fine.

@individual-it
individual-it force-pushed the ui-tests_share_with_group_membership_only branch from 76f5ebf to 8626ac2 Compare November 6, 2017 11:36
@individual-it

Copy link
Copy Markdown
Member Author

added one more test and rebased again

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming CI passes

@individual-it

Copy link
Copy Markdown
Member Author

backport in #29470

@phil-davis
phil-davis deleted the ui-tests_share_with_group_membership_only branch November 6, 2017 16:11
@phil-davis phil-davis mentioned this pull request Nov 7, 2017
9 tasks
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants