UI tests for restricting the sharing - #29406
Conversation
|
@jvillafanez could you please check if the tests described in f0a4b4d#diff-4a8972ffadc126987f05eebd52151aec are what you have programmed |
phil-davis
left a comment
There was a problem hiding this comment.
Just little things.
This seems a good start to testing the sharing restrictions. After this we can easily look through the other sharing settings and make basic UI tests to confirm that other combinations work.
| */ | ||
| private $savedCapabilitiesChanges = []; | ||
|
|
||
| /** |
| Feature: restrict resharing | ||
|
|
||
| As admin | ||
| I would like to be able to forbid the sharing of a received share globaly |
Codecov Report
@@ Coverage Diff @@
## master #29406 +/- ##
=========================================
Coverage 60.47% 60.47%
Complexity 17235 17235
=========================================
Files 1032 1032
Lines 57389 57389
=========================================
Hits 34707 34707
Misses 22682 22682Continue to review full report at Codecov.
|
f0a4b4d to
06a6844
Compare
f28aa0f to
76f5ebf
Compare
|
I suggest rebasing for CI |
|
I think we should include tests for the case where the checkbox aren't checked. Other than that, the tests look fine. |
76f5ebf to
8626ac2
Compare
|
added one more test and rebased again |
phil-davis
left a comment
There was a problem hiding this comment.
LGTM - assuming CI passes
|
backport in #29470 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
UI test to see if various ways of restricting the sharing options work e.g "Share with group membership only" #29241
This PR contains also the changes from #29388 because it depends on them
Related Issue
#29075
Motivation and Context
test sharing behaviour
How Has This Been Tested?
run tests locally, travis will test again
Types of changes
Checklist: