Skip to content

insulate new features#29478

Merged
phil-davis merged 1 commit into
masterfrom
insulate-new-features
Nov 7, 2017
Merged

insulate new features#29478
phil-davis merged 1 commit into
masterfrom
insulate-new-features

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Add the "@insulated" tag to new UI test feature files.

Related Issue

PRs #29388 and #29406

Motivation and Context

The above PRs added new UI test feature files.
All feature files should have the tag "@insulated" so that each scenario is well separated and produces its own SauceLabs video...
The "@insulated" tag was missed in the integration/review process.

How Has This Been Tested?

Travis will tell.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis

Copy link
Copy Markdown
Contributor Author

To confirm the new test behavior is working:

  • check the Travis logs of the jobs with these new feature files, and see that there is a different SauceLabs result link reported for each scenario.

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #29480

@codecov

codecov Bot commented Nov 7, 2017

Copy link
Copy Markdown

Codecov Report

Merging #29478 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29478   +/-   ##
=========================================
  Coverage     60.84%   60.84%           
  Complexity    17238    17238           
=========================================
  Files          1032     1032           
  Lines         57365    57365           
=========================================
  Hits          34904    34904           
  Misses        22461    22461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef2009...9aed21d. Read the comment docs.

@phil-davis
phil-davis merged commit 3da7b8e into master Nov 7, 2017
@phil-davis
phil-davis deleted the insulate-new-features branch November 7, 2017 07:48
@lock

lock Bot commented Aug 2, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants