Skip to content

[stable10] Get translations from correct app#35043

Merged
PVince81 merged 4 commits into
stable10from
stable10-get-translations-from-correct-app
Apr 18, 2019
Merged

[stable10] Get translations from correct app#35043
PVince81 merged 4 commits into
stable10from
stable10-get-translations-from-correct-app

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Backport #35041

@phil-davis
phil-davis requested a review from PVince81 April 17, 2019 11:59
@phil-davis phil-davis self-assigned this Apr 17, 2019
@phil-davis phil-davis mentioned this pull request Apr 17, 2019
11 tasks
@phil-davis
phil-davis force-pushed the stable10-get-translations-from-correct-app branch from 7eb782a to cf7e622 Compare April 17, 2019 13:02
@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35043 into stable10 will increase coverage by 23.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #35043       +/-   ##
===============================================
+ Coverage       40.85%   64.41%   +23.55%     
- Complexity          0    20064    +20064     
===============================================
  Files             116     1286     +1170     
  Lines           11565    76928    +65363     
  Branches         1307     1307               
===============================================
+ Hits             4725    49550    +44825     
- Misses           6459    26997    +20538     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <66.66%> (ø) 0 <0> (ø) ⬇️
#phpunit 65.62% <ø> (+46.32%) 20064 <ø> (+20064) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/app.js 73.37% <50%> (ø) 0 <0> (ø) ⬇️
apps/files_external/lib/config.php 10.71% <0%> (-20.87%) 19% <0%> (+19%)
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0% <0%> (?)
lib/private/Encryption/Keys/Storage.php 91.45% <0%> (ø) 48% <0%> (?)
lib/private/App/CodeChecker/NodeVisitor.php 95.86% <0%> (ø) 54% <0%> (?)
lib/private/RedisFactory.php 0% <0%> (ø) 19% <0%> (?)
apps/dav/lib/Avatars/AvatarNode.php 72% <0%> (ø) 9% <0%> (?)
...s/dav/appinfo/Migrations/Version20170202213905.php 21.05% <0%> (ø) 12% <0%> (?)
apps/dav/lib/Upload/ChunkLocationProvider.php 100% <0%> (ø) 4% <0%> (?)
... and 1165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bb6be...cf7e622. Read the comment docs.

@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35043 into stable10 will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35043      +/-   ##
==============================================
- Coverage       64.46%   64.46%   -0.01%     
  Complexity      20064    20064              
==============================================
  Files            1286     1286              
  Lines           76928    76928              
  Branches         1307     1307              
==============================================
- Hits            49595    49594       -1     
- Misses          26952    26953       +1     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <66.66%> (ø) 0 <0> (ø) ⬇️
#phpunit 65.68% <ø> (-0.01%) 20064 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/app.js 73.37% <50%> (ø) 0 <0> (ø) ⬇️
lib/private/Server.php 86.54% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bb6be...cf7e622. Read the comment docs.

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit 371861f into stable10 Apr 18, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-get-translations-from-correct-app branch April 18, 2019 07:18
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants