Skip to content

Relase 10.2.0 changes#35261

Closed
patrickjahns wants to merge 65 commits into
stable10from
release-10.2.0
Closed

Relase 10.2.0 changes#35261
patrickjahns wants to merge 65 commits into
stable10from
release-10.2.0

Conversation

@patrickjahns

Copy link
Copy Markdown
Contributor

Description

Merge back the changes from 10.2.0 release branch to sync up changes

Related Issue

Motivation and Context

How Has This Been Tested?

🚫

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Vincent Petry and others added 30 commits April 11, 2019 15:21
The uploader is expecting the progress bar element to be in the DOM when
created. This fix makes sure to append the PublicUploadView's element to
the DOM before rendering it.
[10.2] Point to current installation instructions in README
…progress

[10.2.0] Fix missing progress bar in files drop view
[10.2] Dependency bumps for release 10.2.0
[10.2] Wrong translation file referenced for accept & decline share
…load

Remove share permission check from the file upload
js file.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
…release-10.2.0

[10.2.0] Backport of Remove share permission check from the file up…
[10.2.0] Filter unavailable users and remove unavailable shares on polling
[10.2.0] add new capability privateLinksDetailsParam
[10.2.0] Respect 'writable' appdir flag on update
[release-10.2.0] Avoid headers set twice in some situations
sharidas and others added 18 commits May 10, 2019 14:27
Remove update permission for Download/View/Upload
option for public link. And hence the behaviour of
public links created using this option has changed.
1. User cannot delete the files/folders inside this public link.
2. User cannot update the files which are already present
in the public link
3. User cannot rename files.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
…ur-release-10.2.0

[10.2.0] Backport of Fix permission and update behaviour for public link
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
…status

[release-10.2.0] encode jobs that have an array as job value
… upload check

The public link edit template was outside public upload check.
And hence for creating the public link for files the full
permission option was shown. This change tries to address
the issue.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
…lease-10.2.0

[10.2.0] Backport of The public link edit template was outside public upload check
[10.2.0] Treat send attempt as unsuccessful when there is a message.
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
…l-notification

[release-10.2.0] Add webUI tests for share mail notification
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35261 into stable10 will decrease coverage by 0.13%.
The diff coverage is 74.59%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35261      +/-   ##
==============================================
- Coverage       64.52%   64.39%   -0.14%     
+ Complexity      20080    20051      -29     
==============================================
  Files            1289     1285       -4     
  Lines           76947    76848      -99     
  Branches         1299     1308       +9     
==============================================
- Hits            49650    49485     -165     
- Misses          26916    26979      +63     
- Partials          381      384       +3
Flag Coverage Δ Complexity Δ
#javascript 53.66% <83.87%> (+0.45%) 0 <0> (ø) ⬇️
#phpunit 65.53% <71.42%> (-0.19%) 20051 <15> (-29)
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 100% <ø> (+100%) 2 <0> (ø) ⬇️
core/js/sharedialoglinkshareview.js 83.46% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/ajax/undelete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...s/federatedfilesharing/lib/AppInfo/Application.php 45.89% <0%> (-0.97%) 19 <0> (ø)
apps/files_trashbin/ajax/delete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/Helper.php 20.89% <0%> (ø) 47 <0> (ø) ⬇️
core/Command/Background/Queue/Status.php 100% <100%> (ø) 6 <2> (ø) ⬇️
...ederatedfilesharing/lib/FederatedShareProvider.php 61.13% <100%> (-1.53%) 85 <4> (ø)
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de832e7...28bc7ab. Read the comment docs.

@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35261 into stable10 will decrease coverage by 0.13%.
The diff coverage is 74.59%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35261      +/-   ##
==============================================
- Coverage       64.52%   64.39%   -0.14%     
+ Complexity      20080    20051      -29     
==============================================
  Files            1289     1285       -4     
  Lines           76947    76848      -99     
  Branches         1299     1308       +9     
==============================================
- Hits            49650    49485     -165     
- Misses          26916    26979      +63     
- Partials          381      384       +3
Flag Coverage Δ Complexity Δ
#javascript 53.66% <83.87%> (+0.45%) 0 <0> (ø) ⬇️
#phpunit 65.53% <71.42%> (-0.19%) 20051 <15> (-29)
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 100% <ø> (+100%) 2 <0> (ø) ⬇️
core/js/sharedialoglinkshareview.js 83.46% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/ajax/undelete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...s/federatedfilesharing/lib/AppInfo/Application.php 45.89% <0%> (-0.97%) 19 <0> (ø)
apps/files_trashbin/ajax/delete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/Helper.php 20.89% <0%> (ø) 47 <0> (ø) ⬇️
core/Command/Background/Queue/Status.php 100% <100%> (ø) 6 <2> (ø) ⬇️
...ederatedfilesharing/lib/FederatedShareProvider.php 61.13% <100%> (-1.53%) 85 <4> (ø)
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de832e7...28bc7ab. Read the comment docs.

@patrickjahns
patrickjahns requested a review from phil-davis May 17, 2019 15:01
@codecov

codecov Bot commented May 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35261 into stable10 will decrease coverage by 0.13%.
The diff coverage is 74.59%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35261      +/-   ##
==============================================
- Coverage       64.52%   64.39%   -0.14%     
+ Complexity      20080    20051      -29     
==============================================
  Files            1289     1285       -4     
  Lines           76947    76848      -99     
  Branches         1299     1308       +9     
==============================================
- Hits            49650    49485     -165     
- Misses          26916    26979      +63     
- Partials          381      384       +3
Flag Coverage Δ Complexity Δ
#javascript 53.66% <83.87%> (+0.45%) 0 <0> (ø) ⬇️
#phpunit 65.53% <71.42%> (-0.19%) 20051 <15> (-29)
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 100% <ø> (+100%) 2 <0> (ø) ⬇️
core/js/sharedialoglinkshareview.js 83.46% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_trashbin/ajax/undelete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...s/federatedfilesharing/lib/AppInfo/Application.php 45.89% <0%> (-0.97%) 19 <0> (ø)
apps/files_trashbin/ajax/delete.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/js/PublicUploadView.js 67.39% <0%> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/Helper.php 20.89% <0%> (ø) 47 <0> (ø) ⬇️
core/Command/Background/Queue/Status.php 100% <100%> (ø) 6 <2> (ø) ⬇️
...ederatedfilesharing/lib/FederatedShareProvider.php 61.13% <100%> (-1.53%) 85 <4> (ø)
apps/files_versions/js/versionstabview.js 80.41% <100%> (ø) 0 <0> (ø) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de832e7...28bc7ab. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

See #35262 for an equivalent PR with the conflicts resolved...
That may be the easiest/clearest thing to do here?

@phil-davis phil-davis mentioned this pull request May 18, 2019
11 tasks
@phil-davis

Copy link
Copy Markdown
Contributor

PR #35262 did the job here.

@phil-davis phil-davis closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.