Skip to content

[Stable10] Fix openFile method to handle error in acceptance tests#35299

Merged
phil-davis merged 1 commit into
stable10from
stable10-open-file-error
May 22, 2019
Merged

[Stable10] Fix openFile method to handle error in acceptance tests#35299
phil-davis merged 1 commit into
stable10from
stable10-open-file-error

Conversation

@dpakach

@dpakach dpakach commented May 22, 2019

Copy link
Copy Markdown
Contributor

Backport for #35268

@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35299 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35299   +/-   ##
===========================================
  Coverage       64.64%   64.64%           
  Complexity      20089    20089           
===========================================
  Files            1289     1289           
  Lines           76943    76943           
  Branches         1300     1300           
===========================================
  Hits            49738    49738           
  Misses          26821    26821           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.78% <ø> (ø) 20089 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d3c7...09aa112. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented May 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35299 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35299   +/-   ##
===========================================
  Coverage       64.64%   64.64%           
  Complexity      20089    20089           
===========================================
  Files            1289     1289           
  Lines           76943    76943           
  Branches         1300     1300           
===========================================
  Hits            49738    49738           
  Misses          26821    26821           
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.78% <ø> (ø) 20089 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52d3c7...09aa112. Read the comment docs.

@phil-davis
phil-davis merged commit 893bcae into stable10 May 22, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-open-file-error branch May 22, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants