Stabilize PR status lookups and provider session lifecycle

[juliusmarminge]

Summary

• Cache GitHub PR lookups with refresh invalidation and preserve the last known PR during transient failures.
• Normalize Git remotes and improve GitHub/VCS status handling.
• Simplify provider session lifecycle transitions and remove obsolete pending-start behavior and tests.

Testing

• Not run (no test results provided).

---

Note

Medium Risk
Changes visible PR badge behavior on errors and caches PR association separately from other status fields; incorrect sticky fallback rules could show wrong PRs until upstream/remote keys change.

Overview
PR status now uses a separate slow cache for hosting-provider PR lookups (ahead/behind still refresh on the fast status cadence). Transient gh failures return the last known PR instead of clearing the badge, with guards so retargeted upstreams, repointed remotes, or fork changes do not show a stale association.

Explicit invalidateStatus (user refresh, git actions) bumps a PR lookup epoch so live lookups run immediately; VcsStatusBroadcaster.refreshStatus calls that full invalidation instead of only local/remote caches.

GitHub PR list decoding tolerates older gh (< 2.47) payloads missing headRepository.nameWithOwner / owner login by reconstructing owner/repo when possible.

ensureRemote reuses an existing remote when URLs match after shared normalizeGitRemoteUrl (ssh/https, ports, .git, casing). Branch head context tracks headRemoteUrlKey for the sticky-PR matching rules.

^{Reviewed by Cursor Bugbot for commit c0b9cee. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize PR status lookups with caching, fallback state, and provider session lifecycle fixes

• Adds a PR lookup cache in GitManager.ts keyed by branch/upstream/epoch with a 2-minute TTL for hits and 20-second TTL for failures, replacing raw findLatestPr calls on every remote status read.
• On transient lookup failures, retains the last known PR per branch rather than clearing it, and bumps a per-cwd epoch on explicit invalidation to force a fresh lookup.
• VcsStatusBroadcaster.refreshStatus now calls a single invalidateStatus instead of separate local/remote invalidations, ensuring the PR cache epoch is also bypassed on manual refresh.
• Relaxes GitHubPullRequestSchema to tolerate older gh output that omits headRepository.nameWithOwner, reconstructing it from owner login and repo name when available.
• GitVcsDriver.ensureRemote now uses shared normalizeGitRemoteUrl to recognize equivalent remotes across http/ssh variants, schemes, ports, and .git suffix differences.
• Behavioral Change: default-branch PR lookups now only return open PRs; previously closed PRs on the default branch could surface in status.

^{Macroscope summarized c0b9cee.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 865d26b7-02be-4d57-9d62-3427ef7e1529

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/audit-sidebar-git-queries

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

🟡 Medium vcs/GitVcsDriverCore.ts:248

normalizeRemoteUrl treats the port in an SSH URL as part of the repository path. ssh://git@github.com:22/owner/repo.git normalizes to github.com/22/owner/repo, while the equivalent https://github.com/owner/repo.git normalizes to github.com/owner/repo. As a result, ensureRemote fails to match the existing remote and adds a duplicate whenever the SSH URL explicitly includes a port.

The scpLike regex captures host:port/path in group 2 instead of excluding the port. It needs to separate an optional :port from the host before constructing host/path.

-  const scpLike = /^(?:ssh:\/\/)?(?:[^@/:]+@)([^:/]+)[:/](.+)$/.exec(normalized);
+  const scpLike = /^(?:ssh:\/\/)?(?:[^@/:]+@)([^:/]+)(?::\d+)?[:/](.+)$/.exec(normalized);

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/server/src/vcs/GitVcsDriverCore.ts around line 248:

`normalizeRemoteUrl` treats the port in an SSH URL as part of the repository path. `ssh://git@github.com:22/owner/repo.git` normalizes to `github.com/22/owner/repo`, while the equivalent `https://github.com/owner/repo.git` normalizes to `github.com/owner/repo`. As a result, `ensureRemote` fails to match the existing remote and adds a duplicate whenever the SSH URL explicitly includes a port.

The `scpLike` regex captures `host:port/path` in group 2 instead of excluding the port. It needs to separate an optional `:port` from the host before constructing `host/path`.

[macroscopeapp]

Approvability

Verdict: Needs human review

1 blocking correctness issue found. This PR introduces new caching and fallback behavior for PR status lookups, representing significant runtime changes rather than simple fixes. Two unresolved review comments also identify potential bugs in the new logic that should be addressed.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit c0b9cee. Configure here.}

[cursor]

Sticky PR dropped on null URL key

Medium Severity

resolveLastKnownPr clears sticky PR badges prematurely. Transient failures (e.g., git config read errors, gh API issues) can cause headRemoteUrlKey mismatches or null values. The function's strict headRemoteUrlKey comparison then incorrectly invalidates the remembered PR, even if the branch's remote identity is unchanged, affecting fork workflows.

 

^{Reviewed by Cursor Bugbot for commit c0b9cee. Configure here.}