Add 'title' to distinguish multiple projects in actions-plan-preview by t-kikuc · Pull Request #5905 · pipe-cd/pipecd

t-kikuc · 2025-05-30T11:53:41Z

What this PR does:

Added title input
Show title in result header
Avoid minimizing the result with the same title

After this PR is merged, I will update pipe-cd/actions-plan-preview#21 and we'll release.

Example

planpreview config:

jobs:
  plan-preview-alice:
    steps:
      - with:
          api-key: ${{ secrets.PIPECD_PLAN_PREVIEW_API_KEY }} // Project Alice
          title: "Alice Project" // HERE
          ....

  plan-preview-bob:
    steps:
      - with:
          api-key: ${{ secrets.PIPECD_PLAN_PREVIEW_API_KEY }} // Project Bob
          title: "Bob Project" // HERE
          ...

Why we need it:

as described in #5899

Which issue(s) this PR fixes:

Fixes #5899

Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

…review/distinguish-B_args Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

codecov · 2025-05-30T11:55:37Z

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 27.90%. Comparing base (9be5674) to head (9bb4a1f).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
tool/actions-plan-preview/planpreview.go	0.00%	8 Missing ⚠️
tool/actions-plan-preview/main.go	0.00%	6 Missing ⚠️
tool/actions-plan-preview/github.go	80.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5905   +/-   ##
=======================================
  Coverage   27.89%   27.90%           
=======================================
  Files         519      519           
  Lines       55923    55936   +13     
=======================================
+ Hits        15600    15609    +9     
- Misses      39125    39129    +4     
  Partials     1198     1198

Flag	Coverage Δ
.	`23.73% <ø> (-0.02%)`	⬇️
.-pkg-app-pipedv1-plugin-example	`0.00% <ø> (ø)`
.-pkg-app-pipedv1-plugin-kubernetes	`63.32% <ø> (ø)`
.-pkg-app-pipedv1-plugin-kubernetes_multicluster	`64.93% <ø> (ø)`
.-pkg-app-pipedv1-plugin-wait	`35.51% <ø> (ø)`
.-pkg-plugin-sdk	`49.25% <ø> (ø)`
.-tool-actions-gh-release	`19.23% <ø> (ø)`
.-tool-actions-plan-preview	`25.30% <33.33%> (+2.47%)`	⬆️
.-tool-codegen-protoc-gen-auth	`0.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ponkio-o · 2025-05-30T12:11:14Z

 	}
 }
+
+func TestFilterLatestPlanPreviewComment(t *testing.T) {


[IMO] I think it's better to add a test case for a multibyte string.

Thank you!
I added: 9bb4a1f

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

ffjlabo

LGTM

Warashi

LGTM

…5905) * add title to args Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add the title to filter latest comments Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use hash Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix tests Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add multibyte test Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Fix lint errors (#5897) * Fix import grouping by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix linter errors by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Rewrite long if-else to switch Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove unnecessary zero-value initialization Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove unnecessary string conversion Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix to correctly call deferred functions log.Fatalf calls os.Exit(1) and deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix lint errors log.Fatal calls os.Exit, so the deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. This is a workaround to fix the lint errors. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix lint errors Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Initialize the slice with the correct capacity Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Change return type of doComment to int Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add 'title' to distinguish multiple projects in actions-plan-preview (#5905) * add title to args Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add the title to filter latest comments Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use hash Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix tests Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add multibyte test Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Revert "Do treeless clone for git clone to improve performance (#5722)" (#5908) This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Cut release v0.52.1 (#5909) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <3600530+Warashi@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Tetsuya KIKUCHI <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <3600530+Warashi@users.noreply.github.com>

t-kikuc added 5 commits May 29, 2025 20:30

add title to args

c7c32dc

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

Add the title to filter latest comments

92d0e6a

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

Use hash

0f494f4

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

Fix tests

65c311e

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

Merge branch 'master' of https://github.com/pipe-cd/pipecd into planp…

0a328f3

…review/distinguish-B_args Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

t-kikuc requested a review from a team as a code owner May 30, 2025 11:53

t-kikuc requested review from Warashi, ffjlabo and khanhtc1202 May 30, 2025 11:53

github-actions Bot added the area/tool label May 30, 2025

t-kikuc changed the title ~~Planpreview/distinguish b args~~ Add 'title' to distinguish multiple projects in actions-plan-preview May 30, 2025

t-kikuc added the cherry-pick label May 30, 2025

ponkio-o reviewed May 30, 2025

View reviewed changes

add multibyte test

9bb4a1f

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>

ponkio-o approved these changes Jun 2, 2025

View reviewed changes

ffjlabo approved these changes Jun 2, 2025

View reviewed changes

t-kikuc added the v0.52.1 label Jun 2, 2025

t-kikuc enabled auto-merge (squash) June 2, 2025 06:06

Warashi approved these changes Jun 2, 2025

View reviewed changes

t-kikuc merged commit cf0fe25 into master Jun 2, 2025
47 checks passed

t-kikuc deleted the planpreview/distinguish-B_args branch June 2, 2025 06:27

github-actions Bot mentioned this pull request Jun 2, 2025

[bot] Release v0.52.1 #5909

Merged

github-actions Bot mentioned this pull request Jun 2, 2025

Cherry-pick to release-v0.52.x #5911

Merged

github-actions Bot mentioned this pull request Jul 14, 2025

[bot] Release v0.52.2 #6027

Merged

github-actions Bot mentioned this pull request Aug 15, 2025

Release v0.53.0 #6123

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'title' to distinguish multiple projects in actions-plan-preview#5905

Add 'title' to distinguish multiple projects in actions-plan-preview#5905
t-kikuc merged 6 commits into
masterfrom
planpreview/distinguish-B_args

t-kikuc commented May 30, 2025

Uh oh!

codecov Bot commented May 30, 2025 •

edited

Loading

Uh oh!

ponkio-o May 30, 2025

Uh oh!

t-kikuc Jun 2, 2025

Uh oh!

ffjlabo left a comment

Uh oh!

Warashi left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

t-kikuc commented May 30, 2025

Uh oh!

codecov Bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ponkio-o May 30, 2025

Choose a reason for hiding this comment

Uh oh!

t-kikuc Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

ffjlabo left a comment

Choose a reason for hiding this comment

Uh oh!

Warashi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented May 30, 2025 •

edited

Loading