Cherry-pick to release-v0.52.x#5911
Merged
Warashi merged 4 commits intoJun 2, 2025
Merged
Conversation
* Fix import grouping by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix linter errors by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Rewrite long if-else to switch Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove unnecessary zero-value initialization Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove unnecessary string conversion Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix to correctly call deferred functions log.Fatalf calls os.Exit(1) and deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix lint errors log.Fatal calls os.Exit, so the deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. This is a workaround to fix the lint errors. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix lint errors Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Initialize the slice with the correct capacity Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Change return type of doComment to int Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
…5905) * add title to args Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add the title to filter latest comments Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use hash Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix tests Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add multibyte test Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <3600530+Warashi@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
github-actions
Bot
requested review from
Warashi,
ffjlabo and
khanhtc1202
and removed request for
a team
t-kikuc
approved these changes
Jun 2, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v0.52.x #5911 +/- ##
===================================================
- Coverage 27.85% 27.84% -0.01%
===================================================
Files 519 519
Lines 55793 55835 +42
===================================================
+ Hits 15539 15547 +8
- Misses 39070 39102 +32
- Partials 1184 1186 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Warashi
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherry pick of #5897 #5905 #5908 #5909.
Note: You need to close and reopen this PR manually to trigger status check workflows. (Or just click if possible.)