Revert "Do treeless clone for git clone to improve performance"#5908
Merged
Conversation
This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
3b0e76f to
3fff308
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5908 +/- ##
==========================================
- Coverage 27.89% 27.88% -0.02%
==========================================
Files 519 519
Lines 55926 55932 +6
==========================================
- Hits 15603 15596 -7
- Misses 39125 39136 +11
- Partials 1198 1200 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
approved these changes
Jun 2, 2025
Merged
Warashi
added a commit
that referenced
this pull request
Jun 2, 2025
* Fix lint errors (#5897) * Fix import grouping by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix linter errors by make lint/go FIX=true Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Rewrite long if-else to switch Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove unnecessary zero-value initialization Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove unnecessary string conversion Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix to correctly call deferred functions log.Fatalf calls os.Exit(1) and deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix lint errors log.Fatal calls os.Exit, so the deferred functions are not called. This commit changes the _main function to return an integer and call os.Exit from main. This is a workaround to fix the lint errors. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix lint errors Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Initialize the slice with the correct capacity Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Change return type of doComment to int Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add 'title' to distinguish multiple projects in actions-plan-preview (#5905) * add title to args Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add the title to filter latest comments Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Use hash Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Fix tests Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add multibyte test Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Revert "Do treeless clone for git clone to improve performance (#5722)" (#5908) This reverts commit 7e74937. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Cut release v0.52.1 (#5909) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <3600530+Warashi@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Tetsuya KIKUCHI <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Warashi <3600530+Warashi@users.noreply.github.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5722
The eventwatcher calls
repo.CopyToModifyevery time, regardless of whether the event is registered.This causes git clone from remote, e.g., GitHub, every time and costs network I/O.
The solution might be to call it
CopyToModifyonly when the modification occurs.For now, I revert the treeless clone because I don't have enough time to do so.
pipecd/pkg/app/piped/eventwatcher/eventwatcher.go
Lines 322 to 336 in 24a573d