[ci] [fix] [client] Multi topic consumer receive null even if has backlog - #41
Closed
poorbarcode wants to merge 18 commits into
Closed
[ci] [fix] [client] Multi topic consumer receive null even if has backlog#41poorbarcode wants to merge 18 commits into
poorbarcode wants to merge 18 commits into
Conversation
Co-authored-by: tison <wander4096@gmail.com>
…18477) Signed-off-by: tison <wander4096@gmail.com>
…r that has a KeySharedPolicy (apache#18345)
* [Doc][Improve] Add landing pages * Add tutorial pages * Update site2/docs/about.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update developers-landing.md * Create tutorials-produce-consume.md * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Delete developer-landing.md * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update install-deploy-upgrade-landing.md * Update site2/docs/tutorials-topic.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-topic.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Typo * Update site2/docs/tutorials-tenant.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-produce-consume.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/tutorials-namespace.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/install-deploy-upgrade-landing.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * Update site2/docs/how-to-landing.md Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> * fix link and style issues Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com> Co-authored-by: momo-jun <jma@streamnative.io>
apache#18343) ### Motivation Authentication documentation has too many duplicate configurations and some unnecessary configurations. Signed-off-by: Zixuan Liu <nodeces@gmail.com> Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
Fixes: apache#17921 <strong>Note</strong>: This patch will change metrics names `s_bufferedwriter_batch_record_count` and `s_bufferedwriter_batch_oldest_record_delay_time_second`. These two names were first used in this PR apache#17701, and PR apache#17701 hasn't cherry-picked any branches yet, so this change will not cause any breaking changes. ### Motivation https://github.com/poorbarcode/pulsar/actions/runs/3156649582/jobs/5136584463 https://github.com/apache/pulsar/actions/runs/3156649597/jobs/5136596447 #### Problem-1 If the `Prometheus-Colloctor` which typed `Counter` is named 'xxx_count', then the output `metrics-api` will be named 'xxx_count_count'. `TxnLogBufferedWriterMetricsStats` hits this error. https://github.com/apache/pulsar/blob/fb7307d8f4998e42b18df3a4599fd7ec34cb04a9/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriterMetricsStats.java#L105-L106 ---- #### Problem-2 `PrometheusMetricsTest` defines the standard metrics name(see code below): ``` ["_sum", "_bucket", "_count", "_total", "_created"] ``` But the standard Prometheus name has three others( see: https://github.com/prometheus/client_java/blob/c28b901225e35e7c1df0eacae8b58fdfbb390162/simpleclient/src/main/java/io/prometheus/client/Collector.java#L152-L186 ): ``` ["_info", "_gsum", "_gcount"] ``` https://github.com/apache/pulsar/blob/fb7307d8f4998e42b18df3a4599fd7ec34cb04a9/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java#L834-L861 ---- ### Modifications - Make `PrometheusMetricsTest` run with transaction feature - Make txn metrics name conforms to the rule. see: https://prometheus.io/docs/practices/naming/ - Make `PrometheusMetricsTest` support all suffix of prometheus metrics name ### Documentation - [x] `doc-not-needed` (Please explain why) ### Matching PR in forked repository PR in forked repository: - #19
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
poorbarcode
force-pushed
the
fix/multi_consumer_receive_null
branch
from
November 16, 2022 06:35
75581fe to
5af3256
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/pulsarbot rerun-failure-checks