Skip to content

Conversation

@AlLevykin
Copy link
Contributor

No description provided.

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, коммментарии очень беглого обзора, пока рекомендуем прочитать руководство.

@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@lex111 lex111 requested a review from gaearon February 9, 2019 23:20
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я оставил первые несколько комментариев — проблемные места похожи, так что я предлагаю их поправить и пройтись по всему тексту в поисках похожих проблем. Потом посмотрю еще )

Спасибо.

@tesseralis tesseralis mentioned this pull request Feb 10, 2019
88 tasks
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уже лучше! Несколько замечаний.

@gaearon gaearon added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще один раунд, мы близко

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С моей стороны всё ок, оставляю @lex111 на мёрж

@lex111 lex111 merged commit 0672717 into reactjs:master Feb 11, 2019
@lex111
Copy link
Member

lex111 commented Feb 11, 2019

@AlLevykin спасибо!

@gaearon gaearon mentioned this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Author opened the pull-request but it's still being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants