Skip to content

add documentation on howto build just rustc without libstd to the build system#34007

Merged
bors merged 1 commit into
rust-lang:masterfrom
flo-l:improve-hacking-docs
Jun 7, 2016
Merged

add documentation on howto build just rustc without libstd to the build system#34007
bors merged 1 commit into
rust-lang:masterfrom
flo-l:improve-hacking-docs

Conversation

@flo-l

@flo-l flo-l commented Jun 1, 2016

Copy link
Copy Markdown

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@flo-l

flo-l commented Jun 1, 2016

Copy link
Copy Markdown
Author

cc @alexcrichton

@alexcrichton

Copy link
Copy Markdown
Member

We may want to replace the "x86_64-unknown-linux-gnu" here with "$host" perhaps as it'll differ depending on where you're compiling. The explanation may also want to be accompanied with a warning indicating that this may not work as the standard library really does need to be recompiled to be guaranteed to work.

@alexcrichton alexcrichton assigned alexcrichton and unassigned aturon Jun 2, 2016
@flo-l

flo-l commented Jun 2, 2016

Copy link
Copy Markdown
Author

good catch with x86_64-unknown-linux-gnu, fixed it and added some more words of warning regarding libstd.

Comment thread Makefile.in Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more "$host" here

@flo-l

flo-l commented Jun 5, 2016

Copy link
Copy Markdown
Author

fixed again!

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+ 4e87986

@eddyb

eddyb commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

@bors rollup

@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4e87986 with merge 1ef5f79...

bors added a commit that referenced this pull request Jun 6, 2016
add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990
@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4e87986 with merge 71efa91...

bors added a commit that referenced this pull request Jun 6, 2016
add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990
@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4e87986 with merge 3bedec0...

bors added a commit that referenced this pull request Jun 6, 2016
add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference #33990
@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

⛄ The build was interrupted to prioritize another pull request.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
…richton

add documentation on howto build just rustc without libstd to the build system

I searched for days until I found this, maybe this helps other poor souls 😂

for reference rust-lang#33990
bors added a commit that referenced this pull request Jun 7, 2016
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit 4e87986 into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants