Skip to content

Improved documentation for tests/ directory#34060

Merged
bors merged 2 commits into
rust-lang:masterfrom
JDemler:master
Jun 7, 2016
Merged

Improved documentation for tests/ directory#34060
bors merged 2 commits into
rust-lang:masterfrom
JDemler:master

Conversation

@JDemler

@JDemler JDemler commented Jun 3, 2016

Copy link
Copy Markdown
Contributor

This ambigouity problem was already discussed in the forums.

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

Thank you!

@bors

bors commented Jun 6, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit c26703b has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
Improved documentation for tests/ directory

This ambigouity problem was already discussed in the [forums](https://users.rust-lang.org/t/problem-using-external-modules-inside-integration-test-submodule/5312/6).
bors added a commit that referenced this pull request Jun 7, 2016
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit c26703b into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants