Skip to content

Minor changes to variable bindings chapter#34094

Merged
bors merged 1 commit into
rust-lang:masterfrom
abenga:doc_changes_variable_bindings
Jun 7, 2016
Merged

Minor changes to variable bindings chapter#34094
bors merged 1 commit into
rust-lang:masterfrom
abenga:doc_changes_variable_bindings

Conversation

@abenga

@abenga abenga commented Jun 5, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • In "... name as another binding, that's currently in scope, will ...", "
    that's currently in scope"     is not a parenthetical element, and the commas
    can be omitted.
  • Other minor changes.

@rust-highfive

rust-highfive commented Jun 5, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

steveklabnik commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

Thank you! Would you mind rebasing this pull request though, it seems two merge commits have gotten in there.

@abenga @abenga-gro
Minor changes to variable bindings chapter
b014039 
* In "... name as another binding, that's currently in scope, will ...", ",
  that's currently in scope, " is not a parenthetical element, and the commas
  can be omitted.

* Other minor changes.
@abenga

abenga commented Jun 7, 2016

Copy link
Copy Markdown
Contributor Author

Done.

@GuillaumeGomez

GuillaumeGomez commented Jun 7, 2016

Copy link
Copy Markdown
Member

@bors: r=steveklabnik rollup

@bors

bors commented Jun 7, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit b014039 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
@steveklabnik
Rollup merge of rust-lang#34094 - abenga:doc_changes_variable_binding…
31ddf96 
…s, r=steveklabnik

Minor changes to variable bindings chapter

* In "*... name as another binding, that's currently in scope, will ...*", *"
  that's currently in scope"* is not a parenthetical element, and the commas
  can be omitted.

* Other minor changes.
@steveklabnik steveklabnik mentioned this pull request Jun 7, 2016
Merged
bors added a commit that referenced this pull request Jun 7, 2016
@bors
Auto merge of #34139 - steveklabnik:rollup, r=steveklabnik
39a523b 
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit b014039 into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abenga @rust-highfive @steveklabnik @GuillaumeGomez @bors @Manishearth