Remove unnecessary norm_type argument from GLM-Image dits#18382
Remove unnecessary norm_type argument from GLM-Image dits#18382mickqian merged 1 commit intosgl-project:mainfrom
Conversation
haojin2
requested review from
BBuf,
mickqian,
yhyang201 and
yingluosanqian
as code owners
Summary of ChangesHello @haojin2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an initialization error in the GLM-Image DITs model by removing an extraneous Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@zhaochenyang20 this was the small bug I mentioned offline |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the norm_type argument from the ScaleResidualLayerNormScaleShift constructor calls in glm_image.py. As norm_type is a class attribute and not an __init__ parameter, passing it would cause a TypeError. This change fixes the bug and aligns the code with the class definition. The change is correct and improves the robustness of the model initialization.
|
/tag-run-ci-label |
|
|
|
thanks for fixing GLM-Image |
|
The evaluation results is provided in this PR: |
|
I suspect that this PR (#14717) introduced changes that caused glm image to become unavailable. glm image requires transformers >= 5.0.0, so it cannot be added to CI for now, and its availability cannot be guaranteed at all times. |
yingluosanqian
left a comment
yingluosanqian
left a comment
There was a problem hiding this comment.
thanks to fix it.
haojin2
force-pushed
the
glm_image_fix
branch
from
d95e499 to
94982f9
Compare
|
/tag-and-rerun-ci |
… dits (sgl-project#18382) Co-authored-by: Hao Jin <Hao Jin>
… dits (sgl-project#18382) Co-authored-by: Hao Jin <Hao Jin>
* www/pr/ks: (265 commits) [BugFix][PD]Fix metadata_buffer_index leak when aborted in PD (sgl-project#17483) Refactoring Mooncake TE as a shared distributed component (sgl-project#17810) [ModelOPT] Support Qwen 3 Next Coder NVFP4 (sgl-project#18224) Update author information in pyproject.toml (sgl-project#18453) [Kimi-K2.5] Fix missing `quant_config` in `KimiK25` (sgl-project#18440) Add tensor parallelism support to LFM2 ShortConv layers (sgl-project#17777) [diffusion] chore: revise process title (sgl-project#18446) Fix TRT-LLM MLA backend applying k_scale to BF16 KV cache in BMM1 (sgl-project#18396) [diffusion] refactor: group component loaders under the component_loaders/ directory (sgl-project#18438) [ModelOpt] Fix broken Qwen3-235B-A22B-Instruct-2507-NVFP4 launch (sgl-project#18189) [diffusion] feat: support efficient sequence shard (sgl-project#18161) [CI] fix: notebook ci may not working (sgl-project#18417) fix: sync server_args.kv_cache_dtype when detecting FP8 KV cache (sgl-project#18394) [Fix] Fix backend selection after flashinfer version update (sgl-project#18364) [diffusion] platform: support WAN/FLUX/Qwen-Image/Qwen-Image-edit on Ascend (sgl-project#13662) fix: fix NVFP4 Kimi-K2.5 weight mapping and exclude list (sgl-project#18370) [diffusion] feat: support saving videos directly on the server to avoid the overhead of tensor transfer (sgl-project#18253) [diffusion] fix: respect dist_timeout option (sgl-project#18386) [Doc] Fix outdated `--fp4-gemm-backend` documentation (sgl-project#18350) [diffusion] fix: remove unnecessary norm_type argument from GLM-Image dits (sgl-project#18382) ...
5 participants
Motivation
ScaleResidualLayerNormScaleShift does not need explicit
norm_typeargument and will cause errors during initialization. Default value is "layer" defined at https://github.com/sgl-project/sglang/blob/main/python/sglang/multimodal_gen/runtime/layers/layernorm.py#L376Modifications
Deleted
norm_typeargument from calls to ScaleResidualLayerNormScaleShift in glm_image.pyAccuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci/tag-run-ci-label