[CI] fix: notebook ci may not working

[alphabetc1]

Motivation

trying to fix #18430

In the previous code, the Execute Notebooks workflow could be effectively skipped due to a combination of factors:

• When a PR is created (opened), the notebook workflow is not triggered because pull_request.types did not include opened.
• If the PR does not receive any further pushes (synchronize) and no other triggering events occur (such as adding a label),
• Then no notebook workflow run is ever created for that head SHA.
• However, /tag-and-rerun-ci can only rerun jobs if there is already a workflow run record (either skipped or failure) for that head SHA.
• As a result, the entire notebook CI effectively gets skipped.

Adding opened alone only solves part of the problem: the workflow run will at least exist. But even if run-all-notebooks is skipped, the overall workflow often still ends in success instead of skipped. In that case, handle_rerun_failed_ci will not pick it up as a failed/skipped target to rerun. To fully address this, we also need to adjust both call-gate and the finish job (following the pattern used in the PR Test workflow).

how to reproduce

1. Modify files under docs/** and submit a PR.
2. Tag the PR with /tag-and-rerun-ci.
3. After the run-ci label is added, the notebook CI is still not triggered and does not even appear in the Checks list.
   For example:
   [Do NOT MERGE] notebook ci test #18418

Benchmarking and Profiling

See #18416.
After this fix, any non-markdown changes will correctly trigger the notebook CI once it is tagged with /tag-and-rerun-ci.

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Follow the SGLang code style guidance.

Review Process

1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
2. Get approvals from CODEOWNERS and other reviewers.
3. Trigger CI tests with comments or contact authorized users to do so.
   • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
4. After green CI and required approvals, ask Merge Oncalls to merge.

[gemini-code-assist]

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

[zhaochenyang20]

thanks so much for this PR. I found that /tag-and-rerun-ci seems not be the way I think of.

I am thinking of it like, "if there is no tag, then add run-ci tag and run all the CI; if there is alreay tag, just rerun the failed one".

So it's quite different that I think?

[zhaochenyang20]

After this fix, a new PR that modifies docs/** will correctly trigger the notebook CI once it is tagged with /tag-and-rerun-ci.

Not that, as I mentioned, any non-markdown changes should trigger this CI. If there is a single line of code change, even in Python with just a blank line, this CI should also be triggered.

[alphabetc1]

After this fix, a new PR that modifies docs/** will correctly trigger the notebook CI once it is tagged with /tag-and-rerun-ci.

Not that, as I mentioned, any non-markdown changes should trigger this CI. If there is a single line of code change, even in Python with just a blank line, this CI should also be triggered.

Sorry, I didn’t make it clear earlier. Any non-markdown changes should trigger this CI, as shown in the code:

yaml
paths:
  - "python/sglang/**"
  - "docs/**"
paths-ignore:
  - "python/sglang/**/*.md"
  - "docs/**/*.md"

[zhaochenyang20]

#18429

#18429 PR is used to test #18417 PR:

#18417

Basically, we want any code change that is non-markdown only to trigger execute notebook.

Adter #18417 changed, it should works!