[iOS] Fix handler retrieval and mismatched coordinate space#4199
Merged
j-piasecki merged 2 commits intoMay 27, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets iOS gesture handling correctness by improving handler lookup for recognizers and fixing coordinate-space conversion when button hit testing consults gesture handlers.
Changes:
- Updates
findGestureHandlerByRecognizerto use Fabric component-view detection. - Aligns
wantsToHandleEventsAtPointsubview hit-testing with host detector checks. - Converts button hit-test points into the resolved handler recognizer view.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/react-native-gesture-handler/apple/RNGestureHandler.mm |
Adjusts handler lookup and native/virtual detector hit-test view selection. |
packages/react-native-gesture-handler/apple/RNGestureHandlerButton.mm |
Fixes point conversion before asking a resolved handler whether it wants the touch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
approved these changes
May 27, 2026
j-piasecki
deleted the
@jpiasecki/fix-handler-retrieval-and-coordinate-space
branch
m-bert
added a commit
that referenced
this pull request
Jun 11, 2026
## Description Cherry pick thread for release 2.32 ## List of PRs | PR | Original commit | Picked commit | Without confilct | |:----------:|:-------------:|:------:|:--------:| | [[Android] Remove `getChildInDrawingOrderAtIndex`](#4156) | [f1f09bc](f1f09bc) | [d76f2d9](d76f2d9) | ❌ | | [[iOS] Fix duplicated `testID`](#4186) | [7feab6e](7feab6e) | [d1173ec](d1173ec) | ❌ | | [[Android] Fix discrete gestures not triggering `onFinalize`](#4196) | [117087e](117087e) | [06212cf](06212cf) | ✅ | | [[Android] Fix wrong reported number of pointers](#4218) | [f17bcbd](f17bcbd) | [5fd30f6](5fd30f6) | ❌ | | [fix(pods): Fix invalid `react-native/../react-native` resolution for aliases](#4232) | [9a9f8b4](9a9f8b4) | [cacf6c0](cacf6c0) | ✅ | | [Move ruby utils to module](#4245) | [62d0d52](62d0d52) | [3884f30](3884f30) | ❌ | | [[iOS] Fix handler retrieval and mismatched coordinate space](#4199) | [b1da40b](b1da40b) | [2b48a8e](2b48a8e) | ❌ | | [[iOS] Don't iterate to root while resolving recognizer](#4202) | [fba4dcc](fba4dcc) | [b81f2aa](b81f2aa) | ❌ | | [Support React Native 0.86](#4166) | [96dfc00](96dfc00) | [7df6d1a](7df6d1a) | ❌ | | [Fix `RNRenderer` import for React Native 0.86](#4160) | [0417378](0417378) | [6775d33](6775d33) | ❌ | | [Bump `expo` to stable 56](#4227) | [45e6ac8](45e6ac8) | [0478bb5](0478bb5) | ❌ | | [[macOS] Bump example app](#3993) | [8ec0820](8ec0820) | [cfc5dd4](cfc5dd4) | ❌ | | [Bump Reanimated](#4040) | [23d96d9](23d96d9) | [a2101eb](a2101eb) | ❌ | | [fix(Android): apply `numberOfPointers` config to the pointer requirement in `LongPressGestureHandler`](#4253) | [a70c6e3](a70c6e3) | [af40f9b](af40f9b) | ✅ | ## Test plan Tested that example apps are built correctly --------- Co-authored-by: Pieter De Baets <pieter.debaets@gmail.com> Co-authored-by: Mathieu Acthernoene <zoontek@gmail.com> Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com> Co-authored-by: Phil Pluckthun <phil@kitten.sh> Co-authored-by: prashanFOMO <prashan@fomo.family> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three issues:
findGestureHandlerByRecognizerwas relying onreactTagto determine whether a view is managed by React Native. This is no longer set on the new architecture (we do it here, this needs to be investigated). Instead, I changed it to check whether the view is a subclass ofRCTViewComponentViewwhich is a base for Fabric components.shouldHandleTouchin the button component was converting the point to the wrong coordinate space when callingwantsToHandleEventsAtPoint.wantsToHandleEventsAtPointfor api v3 was always trying to get the child of the view the gesture is attached to. Correct when gesture is attached to the detector, not when directly to view (virtual detector/wantsToAttachDirectlyToView: YES).Test plan
Enable "Legacy examples" in the expo app and try to scroll, starting on one of the disabled buttons.
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-05-27.at.12.15.34.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-05-27.at.12.16.11.mov
There's no pointer captured, but in the "before" video, I'm trying to scroll starting on
Nested buttons (sound & ripple).