Move ruby utils to module#4245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR scopes the CocoaPods Ruby helper functions into a dedicated GestureHandlerUtils module to avoid leaking global methods/variables when evaluating the podspec (similar to the approach taken in Reanimated).
Changes:
- Wrap the Ruby utilities in
GestureHandlerUtilsand expose them viamodule_function. - Update the podspec to call
GestureHandlerUtils.get_react_native_minor_versioninstead of a global function.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/scripts/gesture_handler_utils.rb | Moves helper methods into a GestureHandlerUtils module to avoid global namespace pollution. |
| packages/react-native-gesture-handler/RNGestureHandler.podspec | Switches version flag generation to use the new module-scoped utility method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tjzel
approved these changes
Jun 8, 2026
j-piasecki
approved these changes
Jun 9, 2026
m-bert
added a commit
that referenced
this pull request
Jun 11, 2026
## Description Cherry pick thread for release 2.32 ## List of PRs | PR | Original commit | Picked commit | Without confilct | |:----------:|:-------------:|:------:|:--------:| | [[Android] Remove `getChildInDrawingOrderAtIndex`](#4156) | [f1f09bc](f1f09bc) | [d76f2d9](d76f2d9) | ❌ | | [[iOS] Fix duplicated `testID`](#4186) | [7feab6e](7feab6e) | [d1173ec](d1173ec) | ❌ | | [[Android] Fix discrete gestures not triggering `onFinalize`](#4196) | [117087e](117087e) | [06212cf](06212cf) | ✅ | | [[Android] Fix wrong reported number of pointers](#4218) | [f17bcbd](f17bcbd) | [5fd30f6](5fd30f6) | ❌ | | [fix(pods): Fix invalid `react-native/../react-native` resolution for aliases](#4232) | [9a9f8b4](9a9f8b4) | [cacf6c0](cacf6c0) | ✅ | | [Move ruby utils to module](#4245) | [62d0d52](62d0d52) | [3884f30](3884f30) | ❌ | | [[iOS] Fix handler retrieval and mismatched coordinate space](#4199) | [b1da40b](b1da40b) | [2b48a8e](2b48a8e) | ❌ | | [[iOS] Don't iterate to root while resolving recognizer](#4202) | [fba4dcc](fba4dcc) | [b81f2aa](b81f2aa) | ❌ | | [Support React Native 0.86](#4166) | [96dfc00](96dfc00) | [7df6d1a](7df6d1a) | ❌ | | [Fix `RNRenderer` import for React Native 0.86](#4160) | [0417378](0417378) | [6775d33](6775d33) | ❌ | | [Bump `expo` to stable 56](#4227) | [45e6ac8](45e6ac8) | [0478bb5](0478bb5) | ❌ | | [[macOS] Bump example app](#3993) | [8ec0820](8ec0820) | [cfc5dd4](cfc5dd4) | ❌ | | [Bump Reanimated](#4040) | [23d96d9](23d96d9) | [a2101eb](a2101eb) | ❌ | | [fix(Android): apply `numberOfPointers` config to the pointer requirement in `LongPressGestureHandler`](#4253) | [a70c6e3](a70c6e3) | [af40f9b](af40f9b) | ✅ | ## Test plan Tested that example apps are built correctly --------- Co-authored-by: Pieter De Baets <pieter.debaets@gmail.com> Co-authored-by: Mathieu Acthernoene <zoontek@gmail.com> Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com> Co-authored-by: Phil Pluckthun <phil@kitten.sh> Co-authored-by: prashanFOMO <prashan@fomo.family> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In ruby, functions and variables are global by design. In #4232 we dealt with it by changing name of exported function. However, the correct approach would be to keep our utils in separate module. This has also been introduced in Reanimated.
Test plan
pod install