Decouple some model implementations from the app targets - #24331
Merged
Conversation
This will allow us to move `BloggingPromptSettingsReminderDays` to WordPressData as part of #24165 without dragging the `BloggingRemindersScheduler` dependency with us.
This will allow us to move `BloggingPromptSettings` to WordPressData as part of #24165 without dragging over the `BlogDashboardPersonalizationService` dependency.
This will allow us to move `BloggingPromptsAttribution` to WordPressData as part of #24165 without dragging over those dependencies.
Collaborator
mokagio
enabled auto-merge
March 27, 2025 03:53
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24331-3e0f7d5 | |
| Version | 25.8 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 3e0f7d5 | |
| App Center Build | WPiOS - One-Offs #11866 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr24331-3e0f7d5 | |
| Version | 25.8 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 3e0f7d5 | |
| App Center Build | jetpack-installable-builds #10889 |
crazytonyli
approved these changes
Mar 27, 2025
This was referenced Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Extracts some types and extensions in dedicated files to decouple from usages of types that belong to the apps targets and that we are not yet ready to move to WordPressData as part of #24165
Similar to #24326 but with the difference that these changes are not simple
publicadditions, therefore I felt it better to make them in dedicated commit and in a standalone PR for ease of review.