Skip to content

Decouple some model implementations from the app targets - #24331

Merged
mokagio merged 5 commits into
trunkfrom
mokagio/extract-some-model-types-to-files
Mar 27, 2025
Merged

Decouple some model implementations from the app targets#24331
mokagio merged 5 commits into
trunkfrom
mokagio/extract-some-model-types-to-files

Conversation

@mokagio

@mokagio mokagio commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Extracts some types and extensions in dedicated files to decouple from usages of types that belong to the apps targets and that we are not yet ready to move to WordPressData as part of #24165

Similar to #24326 but with the difference that these changes are not simple public additions, therefore I felt it better to make them in dedicated commit and in a standalone PR for ease of review.

mokagio added 5 commits March 27, 2025 14:02
This will allow us to move `BloggingPromptSettingsReminderDays` to
WordPressData as part of #24165 without dragging the
`BloggingRemindersScheduler` dependency with us.
This will allow us to move `BloggingPromptSettings` to WordPressData as
part of #24165 without dragging over the
`BlogDashboardPersonalizationService` dependency.
This will allow us to move `BloggingPromptsAttribution` to WordPressData as
part of #24165 without dragging over those dependencies.
@dangermattic

dangermattic commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mokagio mokagio changed the title Move PostVisibility definition to dedicated file Decouple some model implementations from the app targets Mar 27, 2025
@mokagio
mokagio requested review from crazytonyli and kean March 27, 2025 03:53
@mokagio mokagio self-assigned this Mar 27, 2025
@mokagio mokagio added this to the 25.9 milestone Mar 27, 2025
@mokagio mokagio added Core Data Issues related to Core Data Enhancement labels Mar 27, 2025
@mokagio
mokagio enabled auto-merge March 27, 2025 03:53
@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24331-3e0f7d5
Version25.8
Bundle IDorg.wordpress.alpha
Commit3e0f7d5
App Center BuildWPiOS - One-Offs #11866
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24331-3e0f7d5
Version25.8
Bundle IDcom.jetpack.alpha
Commit3e0f7d5
App Center Buildjetpack-installable-builds #10889
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio
mokagio added this pull request to the merge queue Mar 27, 2025
Merged via the queue into trunk with commit 9462b91 Mar 27, 2025
@mokagio
mokagio deleted the mokagio/extract-some-model-types-to-files branch March 27, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Data Issues related to Core Data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants