Update access level for types that will go into WordPressData – Round 2 - #24348
Merged
Conversation
mokagio
marked this pull request as draft
March 28, 2025 00:06
mokagio
force-pushed
the
mokagio/access-level-updates-continue
branch
from
March 28, 2025 00:41
46c698e to
3cd2d60
Compare
mokagio
force-pushed
the
mokagio/access-level-updates-continue
branch
from
March 30, 2025 20:55
3cd2d60 to
be865fc
Compare
Collaborator
Generated by 🚫 Danger |
mokagio
force-pushed
the
mokagio/access-level-updates-continue
branch
from
March 31, 2025 02:18
b0a0511 to
262b4b4
Compare
All the changes are extracted from the "work bench" work from #24242 with the goal of reducing that PRs diff size to make it easier to review and identify errors.
mokagio
force-pushed
the
mokagio/access-level-updates-continue
branch
from
March 31, 2025 02:22
262b4b4 to
f6df491
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 26914 | |
| Version | PR #24348 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f6df491 | |
| Installation URL | 3a5sdd3afn40o |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 26914 | |
| Version | PR #24348 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f6df491 | |
| Installation URL | 4stdfghm3e71g |
crazytonyli
reviewed
Mar 31, 2025
| store.set(currentBuildVersion(), forKey: Self.lastSanitizationVersionNumber) | ||
|
|
||
| let entityNamesWithRequiredBlogProperties = [ | ||
| // FIXME: Not sure why it's necessary to define [String] as the type. Without it, the NSFetchRequest<NSManagedObject>(entityName: entityName) below does not compile. |
Contributor
There was a problem hiding this comment.
I think that's because there are multiple entityName definitions with mismatch APIs. For example, +[PostCategory entityName] returns an IUO in Swift, and the entityName on all NSManagedObject returns non-optional String. Changing the access level probably also changed how Swift compiler chooses which API to use.
crazytonyli
approved these changes
Mar 31, 2025
kean
approved these changes
Mar 31, 2025
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same rationale as #24326. Made possible by #24331. Part of #24165.