Skip to content

Update access level for types that will go into WordPressData - #24326

Merged
mokagio merged 1 commit into
trunkfrom
mokagio/access-level-updates
Mar 27, 2025
Merged

Update access level for types that will go into WordPressData#24326
mokagio merged 1 commit into
trunkfrom
mokagio/access-level-updates

Conversation

@mokagio

@mokagio mokagio commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

This comes from the "workbench" work from #24242. It basically adds public to a bunch of model-related files, so that when we'll move them to WordPressData, the PR diff will be easier to parse.

Part of #24165

@dangermattic

dangermattic commented Mar 26, 2025

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mokagio
mokagio force-pushed the mokagio/access-level-updates branch from 9b91283 to 38b0445 Compare March 26, 2025 20:22
@mokagio mokagio self-assigned this Mar 26, 2025
@mokagio mokagio added this to the 25.9 milestone Mar 26, 2025
@mokagio mokagio added the Core Data Issues related to Core Data label Mar 26, 2025
@mokagio
mokagio force-pushed the mokagio/access-level-updates branch from 38b0445 to 25cceb0 Compare March 26, 2025 20:28
@wpmobilebot

wpmobilebot commented Mar 26, 2025

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24326-81ec143
Version25.8
Bundle IDorg.wordpress.alpha
Commit81ec143
App Center BuildWPiOS - One-Offs #11867
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Mar 26, 2025

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24326-81ec143
Version25.8
Bundle IDcom.jetpack.alpha
Commit81ec143
App Center Buildjetpack-installable-builds #10890
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio
mokagio force-pushed the mokagio/access-level-updates branch from 25cceb0 to 5cb6e51 Compare March 26, 2025 22:26
@mokagio
mokagio force-pushed the mokagio/access-level-updates branch from 5cb6e51 to 81ec143 Compare March 27, 2025 02:59
@mokagio
mokagio requested review from crazytonyli and kean March 27, 2025 03:54
@mokagio
mokagio marked this pull request as ready for review March 27, 2025 03:54
@mokagio
mokagio added this pull request to the merge queue Mar 27, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 27, 2025
@mokagio
mokagio added this pull request to the merge queue Mar 27, 2025
Merged via the queue into trunk with commit 492cb99 Mar 27, 2025
@mokagio
mokagio deleted the mokagio/access-level-updates branch March 27, 2025 10:56
@sentry

sentry Bot commented Apr 3, 2025

Copy link
Copy Markdown

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ EXC_BREAKPOINT: WordPress/Blog+Post.swift Blog.createPage View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Data Issues related to Core Data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants