Update some imports in preparation for WordPressData - #24411
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27149 | |
| Version | PR #24411 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 98afc2c | |
| Installation URL | 7l66lceu656gg |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27149 | |
| Version | PR #24411 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 98afc2c | |
| Installation URL | 0ne9pbe1r268g |
mokagio
changed the title
#import "AccountService.h" from MediaService.m
mokagio
force-pushed
the
mokagio/wordpressdata-precursor-nioeno
branch
from
April 4, 2025 01:22
b345a4f to
6ad2196
Compare
`MenuItem` was not used in the interface. Moving the import in the implementation will make it cleaner to update once WordPressData is integrated.
Will make possible to move `PostService` to WordPressData without carrying `CommentService`.
Notice we had to update the `MenuItemAbstractPostsViewController` implementation accordingly
Before, they seemed to implicitly work via the bridging header import.
mokagio
force-pushed
the
mokagio/wordpressdata-precursor-nioeno
branch
from
April 5, 2025 00:45
e6f7fe6 to
c2f57ef
Compare
mokagio
commented
Apr 5, 2025
| /// | ||
| @objc | ||
| public func incrementAutoUploadFailureCount() { | ||
| func incrementAutoUploadFailureCount() { |
Contributor
Author
There was a problem hiding this comment.
If you expand the diff, you'll see the whole extension is public
mokagio
marked this pull request as ready for review
April 6, 2025 21:25
mokagio
requested review from
Copilot,
crazytonyli and
kean
and removed request for
Copilot
April 6, 2025 21:25
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (13)
- WordPress/Classes/Models/Theme.m: Language not supported
- WordPress/Classes/Services/MediaService.m: Language not supported
- WordPress/Classes/Services/PostService.h: Language not supported
- WordPress/Classes/Services/PostService.m: Language not supported
- WordPress/Classes/Services/ReaderSiteService.h: Language not supported
- WordPress/Classes/System/WordPress-Bridging-Header.h: Language not supported
- WordPress/Classes/ViewRelated/Menus/Controllers/MenuItemAbstractPostsViewController.m: Language not supported
- WordPress/Classes/ViewRelated/Menus/Controllers/MenuItemTypeViewController.h: Language not supported
- WordPress/Classes/ViewRelated/Menus/Controllers/MenuItemTypeViewController.m: Language not supported
- WordPress/Classes/ViewRelated/Menus/Views/MenuItemSourceHeaderView.h: Language not supported
- WordPress/Classes/ViewRelated/Menus/Views/MenuItemSourceHeaderView.m: Language not supported
- WordPress/Classes/ViewRelated/Menus/Views/MenuItemTypeSelectionView.h: Language not supported
- WordPress/Classes/ViewRelated/Menus/Views/MenuItemTypeSelectionView.m: Language not supported
Comments suppressed due to low confidence (4)
WordPress/Classes/Models/Media.swift:12
- The public access modifier was removed from this method, making it internal. Verify that this change is intentional, especially given its @objc annotation, which might require public visibility.
func incrementAutoUploadFailureCount() {
WordPress/Classes/Models/Media.swift:19
- Removing the public access modifier here changes the method’s accessibility. Ensure that this is an intended change, considering its role in the public API for media auto-upload handling.
func resetAutoUploadFailureCount() {
WordPress/Classes/Models/Media.swift:47
- The public access modifier was removed from the mimeType property. Confirm whether this property should remain publicly accessible via @objc or if its scope should indeed be restricted.
@objc var mimeType: String? {
WordPress/Classes/Jetpack/Utility/SharedDataIssueSolver.swift:32
- [nitpick] The update changes migrateAuthKey from internal to public. Please verify that this improvement aligns with the intended design, as it differs from similar methods in Media.swift.
public func migrateAuthKey() {
crazytonyli
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same rationale as #24326 and #24348. Part of #24165, all these requirements have been discovered in #24378.