Version 0.6.0.#155
Merged
Merged
Conversation
- Add line breaks to top headers. - Remove redundant trailing heading markdown delimiters. - Add configuration guide from now-removed wpvip.com page. - Fix some typos and missing code delimiters. - Use ordered numbers for installation list as this then looks better when reading the raw markdown file. - Remove headings for individual screenshot references. - Switched fenced code blocks to use tildes as this works better with the readme parser on WPORG. - Reformated code blocks to better follow WP coding standards. Also, removed readme.txt to keep a canonical source of information.
This workflow will run whenever a non-pre-release release is made.
- Add allow-plugins configuration for the two Composer plugins. - Switch from `yoast/phpunit-polyfills` to `yoast/wp-test-utils` which includes a newer version of PHPUnit Polyfills and some other bits useful for running WP / integration tests. - Remove PHPCS and PHPUnit direct dependencies as they are included via other direct dependencies.
- Make the testcase extend from the WP-Test-Utils testcase. - Rename the file containing the tests to PSR-4 (needed for PHPUNit 10 support) - Update assertions, including not using assertions that no longer exist. - Rename tests to use snake_case, so they read better with the Testdox format. - Update the bootstrap to work with WP Test Utils. - Add PHPUnit's cache file to .gitignore. - Update the composer test script. - Move integration test-related files into a new tests/Integrations directory, to allow for future unit tests as well. - Refresh PHPUnit config file for PHPUnit 9 and best practices.
- Test multiple PHP versions. - Allows for not checking PHPUnit XML file for PHP 7.1, as that uses PHPUnit 7.5, which doesn’t support testdox and coverage elements.
Workflows were already using correct minimum versions. Fixes #130.
It is known that tests will fail as WP core is not yet compatible, so it's not even worth testing this.
It is known that tests will fail as WP core is not yet compatible, so it's not even worth testing this.
This is a PSR-1 best practice, and essential for good code organisation.
If the PHP magic `__FILE__` value for the plugin root file is captured, then all the values can be worked out as needed rather than abstracting into new constants. The version constant isn't used by this plugin currently, but it may be in the future, and other code may want to know what version of the plugin is active.
There are no functions defined in the views.
- Adds some escaping to some strings in the UI. - Makes some strings translatable. - Cleans up the labels for registering the post type. - Removes `load_plugin_textdomain()` call as the plugin requires more than WP 4.6. Doesn't fix the strings added via JavaScript as that needs more thought. See #129
The plugin isn't a tool as such, so the settings page should be under the Settings menu item to make it more intuitive to find.
Makes it easier to discover the settings after activation.
- Extracts the logic for getting the output HTML into a new `get_acm_tag()` method. - The `action_acm_tag()` method now just echoes the result of a call to `get_acm_tag()`. It no longer supports an `$echo` parameter. - The `shortcode()` method now calls and returns `get_acm_tag()`, instead of `action_acm_tag()` with a `false` echo parameter. Closes #94.
- Move methods for adding contextual help into its own class. - Remove the reliance on a markdown parsing library and trying to read from `readme.txt` (file already deleted). - Refresh HTML in conditionals page to remove redundant links. - Add internationalization functions to help content. Closes #134.
The screenshots hadn't been updated since October 2012 (around WordPress 3.4). Time for some fresh ones!
Props to @johnbillion for the work he had done on https://github.com/johnbillion/user-switching that this work is very minorly tweaked from. - The README.md contains a HTML comment as a placeholder. - During the deploy workflow (which happens when a non-pre-release release is made from a tag), it connects to the GitHub API, and pulls down previous release notes, removes any pre-release entries, sorts them into order, and loops through to create a string of headings and release notes. - This then replaces the HTML comment in the README.md file. Now instead of maintaining release notes in a CHANGELOG file or in the README, AND also in the GitHub release notes, it's now a single location (GitHub release notes). The `changelog.js` workflow script can also be called locally, and this will do a one-time replacement of the HTML comment (for testing or removal of this automation). It needs a GitHub personal access token, and then call: TOKEN=... GITHUB_REPOSITORY='Automattic/ad-code-manager' node .github/workflows/changelog.js
It can be easy to forget to update a version number somewhere just before release, but this can be made much easier with this script.
GaryJones
added
the
type: maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag and release is scheduled for Monday 21st March.
Milestone with completed issues and pull requests
Release Notes:
The tag should be applied to the merge commit on
master.