fix: wait for accounts to catch up with notes when deployed

[alexghr]

Fix #466. This PR ensures that the PXE (and its Synchronizer service) are fully synced up with the node before accepting transactions.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit a062026d and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,960	868,088	3,449,468
l1_rollup_execution_gas	842,047	3,595,196	22,204,837
l2_block_processing_time_in_ms	1,962 (-1%)	7,507 (-1%)	29,494 (-1%)
note_successful_decrypting_time_in_ms	291 (-3%)	866 (+1%)	3,142 (-2%)
note_trial_decrypting_time_in_ms	95.0 (-5%)	76.0 (+12%)	135 (+1%)
l2_block_building_time_in_ms	13,488 (+2%)	52,388	209,331
l2_block_rollup_simulation_time_in_ms	12,124 (+2%)	47,101	188,204
l2_block_public_tx_process_time_in_ms	1,318 (+1%)	5,153 (-1%)	20,633

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	21,399 (-1%)	41,820 (-1%)
note_history_successful_decrypting_time_in_ms	1,987 (-2%)	3,892 (-1%)
note_history_trial_decrypting_time_in_ms	121 (+1%)	142 (-1%)
node_database_size_in_bytes	1,633,150	1,101,069
pxe_database_size_in_bytes	29,748	59,307

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	772 (-1%)	61,697	18,905
private-kernel-ordering	123 (-1%)	24,297	8,153
base-rollup	1,769	656,311	814
root-rollup	83.3 (+4%)	4,072	1,097
private-kernel-inner	789	81,568	18,905
public-kernel-private-input	41.4	41,519	18,841
public-kernel-non-first-iteration	26.2	41,497	18,841
merge-rollup	0.891 (-8%)	2,592	873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	8,787	27,547

[PhilWindle]

I think we still need to prevent somebody doing the following don't we?

1. User adds their account contract to the PXE via 'addContracts'.
2. User calls 'registerAccount' on the PXE to add their account and start a note processor catch-up.
3. User sends transaction before the note processor is synched. I think we should reject the attempt to do so for the time being.

[alexghr]

I've updated the PR and now both deploying and registering an account with PXE will wait for it to fully sync up.