chore: disable circuits tasks#3253
Merged
Merged
Conversation
rahul-kothari
pushed a commit
that referenced
this pull request
Nov 7, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.2</summary> ## [0.14.2](aztec-packages-v0.14.1...aztec-packages-v0.14.2) (2023-11-07) ### Features * Load private tests and docs ([#3243](#3243)) ([f3d8aae](f3d8aae)), closes [#1285](#1285) * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) ### Bug Fixes * Wait for accounts to catch up with notes when deployed ([#2834](#2834)) ([a8f3119](a8f3119)) ### Miscellaneous * Add noir-protocol-circuits to deploy_npm ([#3268](#3268)) ([1a22cae](1a22cae)) * Aztec-cli better volume mounting strategy ([#3138](#3138)) ([d40460e](d40460e)) * Disable circuits tasks ([#3253](#3253)) ([e8945f8](e8945f8)) </details> <details><summary>barretenberg.js: 0.14.2</summary> ## [0.14.2](barretenberg.js-v0.14.1...barretenberg.js-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) </details> <details><summary>barretenberg: 0.14.2</summary> ## [0.14.2](barretenberg-v0.14.1...barretenberg-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Nov 8, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@aztec-packages-v0.14.1...aztec-packages-v0.14.2) (2023-11-07) ### Features * Load private tests and docs ([#3243](AztecProtocol/aztec-packages#3243)) ([f3d8aae](AztecProtocol/aztec-packages@f3d8aae)), closes [#1285](AztecProtocol/aztec-packages#1285) * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) ### Bug Fixes * Wait for accounts to catch up with notes when deployed ([#2834](AztecProtocol/aztec-packages#2834)) ([a8f3119](AztecProtocol/aztec-packages@a8f3119)) ### Miscellaneous * Add noir-protocol-circuits to deploy_npm ([#3268](AztecProtocol/aztec-packages#3268)) ([1a22cae](AztecProtocol/aztec-packages@1a22cae)) * Aztec-cli better volume mounting strategy ([#3138](AztecProtocol/aztec-packages#3138)) ([d40460e](AztecProtocol/aztec-packages@d40460e)) * Disable circuits tasks ([#3253](AztecProtocol/aztec-packages#3253)) ([e8945f8](AztecProtocol/aztec-packages@e8945f8)) </details> <details><summary>barretenberg.js: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@barretenberg.js-v0.14.1...barretenberg.js-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) </details> <details><summary>barretenberg: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@barretenberg-v0.14.1...barretenberg-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the most basic, we should disable these until we're doing anything with circuits cpp again.
If all goes well, this code will go away as we're moving to Noir kernel circuits (my vote is for not quite yet, but no strong opinions).
Amendment after feedback: Keeps x86 tests around while we reach parity.